Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review / Improve French Translation #851

Open
2 tasks done
nscuro opened this issue May 8, 2024 · 4 comments
Open
2 tasks done

Review / Improve French Translation #851

nscuro opened this issue May 8, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues eligible for Hacktoberfest contributions i18n Issues and PRs related to localization p3 Nice-to-have features size/S Small effort

Comments

@nscuro
Copy link
Member

nscuro commented May 8, 2024

Current Behavior

The current French translation is machine-generated, and most definitely will contain mistakes.

Proposed Behavior

Have a native speaker review and improve the translation.

The translation file is located here: https://github.com/DependencyTrack/frontend/blob/master/src/i18n/locales/fr.json

Instructions for working on translations is here: https://github.com/DependencyTrack/frontend?tab=readme-ov-file#adding-or-improving-translations

Checklist

@nscuro nscuro added enhancement New feature or request good first issue Good for newcomers size/S Small effort i18n Issues and PRs related to localization p3 Nice-to-have features labels May 8, 2024
@molusk
Copy link
Contributor

molusk commented May 14, 2024

Hi,
I will work on this one but I may miss some translations. I have already some that seem odd but I don't know the right terminology.
Anyway, I think I can improve the current translation :)

Thank you for integrating this feature, it will help some of my colleagues to better understand this great tool !

@msymons
Copy link
Member

msymons commented May 23, 2024

@molusk, do not worry about being incomplete when it comes to correcting the translation of keys. Every little bit helps.

When it come to keys where the existing translation is incorrect (or just odd) then simply identifying which those are is actually half the battle. I would suggest just trying your best and then we can see about getting a PR review from another French speaker.

@molusk
Copy link
Contributor

molusk commented May 24, 2024

Thank’s @msymons, that’s my plan, I think I may be able to make that PR today, I already reviewed about 750 keys.

Some of them were source of debate in my team without getting any solution in french (the OWASP panel in particular is very tricky to understand and translate). In some cases, we may end up keeping the english keys rather than a poorly chosen french ones.

I also noticed some keys were not translated in english, I will check whether someone else did it before or I should also issue a PR.

@molusk molusk mentioned this issue May 24, 2024
2 tasks
@molusk
Copy link
Contributor

molusk commented May 24, 2024

I made the PR, any french speaker is welcome to review it but I think my translation is already way better than the automatic one 😉
There are still few things I am not happy with, all comments are welcome.

@molusk molusk mentioned this issue Jul 24, 2024
2 tasks
@leec94 leec94 added the hacktoberfest Issues eligible for Hacktoberfest contributions label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues eligible for Hacktoberfest contributions i18n Issues and PRs related to localization p3 Nice-to-have features size/S Small effort
Projects
None yet
Development

No branches or pull requests

4 participants