Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some suggestions for rl-games #194

Open
ankurhanda opened this issue Aug 8, 2022 · 1 comment
Open

some suggestions for rl-games #194

ankurhanda opened this issue Aug 8, 2022 · 1 comment

Comments

@ankurhanda
Copy link
Collaborator

ankurhanda commented Aug 8, 2022

  • Allow masking of some environments to allow for validation of the policies at outside the DR ranges they are trained on.
  • Dropout is not supported yet but it would be nice to have. In general, it would be nice to have a support for arbitrary networks to be plugged in without going through YAML etc. or changing rl-games code in any way.
  • Allow for changing the LSTM states outside rl-games if possible. We may want to corrupt LSTM states on the fly as another adversarial perturbation to make the policies robust to this.
  • Allow test=True with a checkpoint. @ArthurAllshire has already done it but I think it would be good to have that in the same wrapper. Should be pretty straightforward and will make our lives very easy.
  • unit tests for single-gpu / multi-gpu implementations, checking memory limits etc.
@Denys88
Copy link
Owner

Denys88 commented Aug 13, 2022

thanks @ankurhanda and @ArthurAllshire for the feedbacks.
I finally got free weekend :)

  1. Masking - will be implemented
  2. what do you mean by arbitrary nerworks? It is possible to create custom neural network right now. Here is example in my custom branch with transformers and neural network from the OpenAI paper: https://github.com/Denys88/IsaacGymEnvs/blob/main/isaacgymenvs/learning/networks/ig_networks.py
  3. We can try but not sure it will work. I found that it is very hard to learn something meaningful in LSTM and if we corrupt it I believe we will just help NN to learn to ignore states.
  4. Could you clarify. It might be more IG side issue.
  5. I have plans to implement unittests. Also it would be nice to see more tests in IG too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants