Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bundles property not deeply reactive #673

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Aug 16, 2021

fixes #672

@Demivan Demivan added the Type: Bug Something isn't working label Aug 16, 2021
@github-actions
Copy link

Size report

Path Size
fluent-vue.global.prod.js 2.12 KB (+0.24% 🔺)

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #673 (4fe3f70) into develop (e2b6671) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #673   +/-   ##
========================================
  Coverage    96.86%   96.86%           
========================================
  Files           12       12           
  Lines          255      255           
  Branches        42       42           
========================================
  Hits           247      247           
  Misses           8        8           
Flag Coverage Δ
vue-2 80.00% <100.00%> (ø)
vue-3 90.58% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fluent-vue/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b6671...4fe3f70. Read the comment docs.

@Demivan Demivan changed the title Make bundle iterator not deeply reactive Make bundles property not deeply reactive Aug 16, 2021
@Demivan Demivan merged commit 1f56144 into develop Aug 16, 2021
@Demivan Demivan deleted the fix-deep-reactive branch August 28, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Make bundle array not deeply reactive
1 participant