Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directive not updating on locale change with Vue 3.1.0 #621

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Jun 7, 2021

No description provided.

@Demivan Demivan added the Type: Bug Something isn't working label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #621 (1e8b261) into develop (f1602cf) will increase coverage by 3.06%.
The diff coverage is 72.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
+ Coverage    81.30%   84.36%   +3.06%     
===========================================
  Files           11       11              
  Lines          246      243       -3     
  Branches        40       37       -3     
===========================================
+ Hits           200      205       +5     
+ Misses          30       26       -4     
+ Partials        16       12       -4     
Flag Coverage Δ
vue-2 78.60% <60.00%> (+2.58%) ⬆️
vue-3 78.18% <72.00%> (+2.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fluent-vue-loader/src/index.ts 0.00% <0.00%> (ø)
packages/fluent-vue/src/TranslationContext.ts 100.00% <ø> (ø)
packages/fluent-vue/src/util/camelize.ts 75.00% <50.00%> (ø)
packages/fluent-vue/src/composition.ts 97.50% <80.00%> (+5.19%) ⬆️
packages/fluent-vue/src/vue/directive.ts 76.08% <85.71%> (+12.62%) ⬆️
packages/fluent-vue/src/getOrderedBundles.ts 100.00% <100.00%> (ø)
packages/fluent-vue/src/index.ts 100.00% <100.00%> (ø)
packages/fluent-vue/src/inheritBundle.ts 100.00% <100.00%> (ø)
packages/fluent-vue/src/util/warn.ts 50.00% <100.00%> (ø)
packages/fluent-vue/src/vue/component.ts 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5dcbe...1e8b261. Read the comment docs.

@Demivan Demivan changed the title Fix directive not updating on language change with Vue 3 Fix directive not updating on locale change with Vue 3.1.0 Jun 7, 2021
@Demivan Demivan merged commit 423f521 into develop Jun 7, 2021
@Demivan Demivan deleted the fix-vue-3-1 branch June 7, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant