Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using useFluent method from Vue 2 #612

Merged
merged 4 commits into from
Jun 2, 2021

Conversation

Demivan
Copy link
Member

@Demivan Demivan commented Jun 2, 2021

fixes #611

@Demivan Demivan changed the title Fix error when using useFluent method from Vue 2 Fix error when using useFluent method from Vue 2 Jun 2, 2021
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #612 (5efdff1) into develop (38897a8) will increase coverage by 2.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
+ Coverage    76.20%   78.22%   +2.01%     
===========================================
  Files           11       11              
  Lines          248      248              
  Branches        43       42       -1     
===========================================
+ Hits           189      194       +5     
+ Misses          43       38       -5     
  Partials        16       16              
Flag Coverage Δ
vue-2 73.38% <90.90%> (+2.01%) ⬆️
vue-3 72.58% <90.90%> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fluent-vue/src/vue/component.ts 92.59% <75.00%> (+3.70%) ⬆️
packages/fluent-vue/src/composition.ts 75.00% <100.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38897a8...5efdff1. Read the comment docs.

@Demivan Demivan added the Type: Bug Something isn't working label Jun 2, 2021
@Demivan Demivan merged commit dbb6eb9 into develop Jun 2, 2021
@Demivan Demivan deleted the fix-vue-2-composition-api branch June 2, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Composition api useFluent throws when used with Vue 2
1 participant