Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass message attributes as i18n component slots props #472

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

davidrios
Copy link
Contributor

No description provided.

packages/fluent-vue/src/vue/component.ts Outdated Show resolved Hide resolved
packages/fluent-vue/src/vue/component.ts Outdated Show resolved Hide resolved
packages/fluent-vue/src/vue/component.ts Outdated Show resolved Hide resolved
@davidrios
Copy link
Contributor Author

Hey. What's the method of incorporating the lastest commits from develop here that you prefer? Rebase, merge, etc.

@Demivan
Copy link
Member

Demivan commented Apr 12, 2021

It does not matter. I'm squashing on pull request merge anyway. So use what you prefer.

@Demivan Demivan merged commit e7476f5 into fluent-vue:develop Apr 13, 2021
@Demivan
Copy link
Member

Demivan commented Apr 13, 2021

Thank you for your contribution! This is really nice feature to have.
I'm going publish this later today.

@Demivan Demivan added the Type: Feature Includes new features label Apr 13, 2021
@Demivan Demivan changed the title feat(component): implement feature discussed in issue #471 Pass message attributes as i18n component slots props Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Includes new features
Development

Successfully merging this pull request may close these issues.

2 participants