diff --git a/src/_tests/fixtures/38979/_downloads.json b/src/_tests/fixtures/38979/_downloads.json new file mode 100644 index 000000000..9f5bce8b1 --- /dev/null +++ b/src/_tests/fixtures/38979/_downloads.json @@ -0,0 +1,3 @@ +{ + "estree": 8537567 +} \ No newline at end of file diff --git a/src/_tests/fixtures/38979/_owners.json b/src/_tests/fixtures/38979/_owners.json new file mode 100644 index 000000000..45633574d --- /dev/null +++ b/src/_tests/fixtures/38979/_owners.json @@ -0,0 +1,6 @@ +{ + "allOwners": [ + "RReverser" + ], + "anyPackageIsNew": false +} \ No newline at end of file diff --git a/src/_tests/fixtures/38979/_response.json b/src/_tests/fixtures/38979/_response.json new file mode 100644 index 000000000..0ee26863c --- /dev/null +++ b/src/_tests/fixtures/38979/_response.json @@ -0,0 +1,2478 @@ +{ + "data": { + "repository": { + "pullRequest": { + "id": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "title": "feat: Add `es‑abstract` [WIP]", + "lastEditedAt": "2019-10-22T21:40:07Z", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "authorAssociation": "CONTRIBUTOR", + "baseRef": { + "name": "master", + "__typename": "Ref" + }, + "changedFiles": 72, + "createdAt": "2019-10-08T18:19:50Z", + "labels": { + "nodes": [ + { + "name": "New Definition", + "__typename": "Label" + }, + { + "name": "Other Approved", + "__typename": "Label" + } + ], + "__typename": "LabelConnection" + }, + "isDraft": false, + "mergeable": "UNKNOWN", + "number": 38979, + "state": "OPEN", + "headRefOid": "222334139e52fc16369464cfb5dc95c82f71192f", + "timelineItems": { + "nodes": [ + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2019-10-08T18:22:32Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2019-10-15T01:26:04Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2019-10-17T21:31:10Z" + }, + { + "__typename": "ReadyForReviewEvent", + "createdAt": "2019-10-18T22:52:06Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2019-10-18T23:06:50Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-19T14:41:07Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-19T15:26:36Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T21:39:56Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:31:54Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-11-07T13:40:31Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-11-07T13:53:10Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-12-30T21:53:58Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:41Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:42Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:43Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:43Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:44Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:12:45Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2020-05-12T04:51:03Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "sandersn", + "__typename": "User" + }, + "createdAt": "2020-05-12T15:11:44Z" + }, + { + "__typename": "IssueComment", + "author": { + "login": "orta", + "__typename": "User" + }, + "createdAt": "2020-05-12T15:13:19Z" + } + ], + "__typename": "PullRequestTimelineItemsConnection" + }, + "reviews": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:06:14Z", + "__typename": "PullRequestReviewComment" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:08:14Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:09:08Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299527429", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:13:23Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:13:23Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299531875", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:14:17Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:14:17Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299532394", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:16:48Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:16:48Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299533922", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:19:18Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:19:19Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299535415", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:21:37Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:21:37Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299536732", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "efd85c46cbcbd5a8652425ab5fe15d1a2adb2935", + "abbreviatedOid": "efd85c4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-09T16:29:00Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-09T16:29:00Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-299541130", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "commit": { + "oid": "0e6e7f4d543b37e7862868499883a4afb3f59e5c", + "abbreviatedOid": "0e6e7f4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "createdAt": "2019-10-22T21:42:08Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "MEMBER", + "state": "DISMISSED", + "submittedAt": "2019-10-22T21:43:25Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305526346", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "0e6e7f4d543b37e7862868499883a4afb3f59e5c", + "abbreviatedOid": "0e6e7f4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:13:30Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:13:30Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305539323", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "commit": { + "oid": "0e6e7f4d543b37e7862868499883a4afb3f59e5c", + "abbreviatedOid": "0e6e7f4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:17:22Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "MEMBER", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:17:22Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305540662", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "commit": { + "oid": "0e6e7f4d543b37e7862868499883a4afb3f59e5c", + "abbreviatedOid": "0e6e7f4", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "weswigham", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:20:54Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "MEMBER", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:20:55Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305541896", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "e40b41f143dd741340b23fe88184a42b881775e5", + "abbreviatedOid": "e40b41f", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:34:25Z", + "__typename": "PullRequestReviewComment" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:36:11Z", + "__typename": "PullRequestReviewComment" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:37:27Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:38:44Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305546461", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "e40b41f143dd741340b23fe88184a42b881775e5", + "abbreviatedOid": "e40b41f", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:40:47Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:40:47Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305548491", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "e40b41f143dd741340b23fe88184a42b881775e5", + "abbreviatedOid": "e40b41f", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:49:50Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:49:50Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305551320", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "44403f972f64bf11ba9f1c724f8ad6505b4cf0eb", + "abbreviatedOid": "44403f9", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:50:52Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:50:52Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305551653", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "44403f972f64bf11ba9f1c724f8ad6505b4cf0eb", + "abbreviatedOid": "44403f9", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:51:49Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:51:50Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305551943", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "f2c94a555651e7aa8a9f344c26caae3a3020377e", + "abbreviatedOid": "f2c94a5", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:54:33Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:54:33Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305552800", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "sandersn", + "__typename": "User" + }, + "commit": { + "oid": "3aba5ac906488433b92621605ef1eaceff29679b", + "abbreviatedOid": "3aba5ac", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "sandersn", + "__typename": "User" + }, + "createdAt": "2019-10-22T22:56:08Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "MEMBER", + "state": "COMMENTED", + "submittedAt": "2019-10-22T22:56:09Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305553285", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "3aba5ac906488433b92621605ef1eaceff29679b", + "abbreviatedOid": "3aba5ac", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "createdAt": "2019-10-22T23:00:36Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T23:00:36Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305554734", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "commit": { + "oid": "3aba5ac906488433b92621605ef1eaceff29679b", + "abbreviatedOid": "3aba5ac", + "__typename": "Commit" + }, + "comments": { + "nodes": [ + { + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "createdAt": "2019-10-22T23:00:52Z", + "__typename": "PullRequestReviewComment" + } + ], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "COMMENTED", + "submittedAt": "2019-10-22T23:00:52Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-305554810", + "__typename": "PullRequestReview" + }, + { + "author": { + "login": "ljharb", + "__typename": "User" + }, + "commit": { + "oid": "222334139e52fc16369464cfb5dc95c82f71192f", + "abbreviatedOid": "2223341", + "__typename": "Commit" + }, + "comments": { + "nodes": [], + "__typename": "PullRequestReviewCommentConnection" + }, + "authorAssociation": "CONTRIBUTOR", + "state": "APPROVED", + "submittedAt": "2020-05-12T04:51:52Z", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979#pullrequestreview-409696628", + "__typename": "PullRequestReview" + } + ], + "__typename": "PullRequestReviewConnection" + }, + "commits": { + "totalCount": 24, + "nodes": [ + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-10-08T18:20:00Z", + "committedDate": "2019-10-18T22:50:53Z", + "pushedDate": null, + "abbreviatedOid": "c44bcfe", + "oid": "c44bcfef5ae7fb71d20e57ebc4430d5cf412b1d2", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-10-09T15:20:00Z", + "committedDate": "2019-10-18T22:50:53Z", + "pushedDate": null, + "abbreviatedOid": "5cc1196", + "oid": "5cc1196c37e559f3e33c6711c4a1996d24d3f870", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-10-09T15:30:00Z", + "committedDate": "2019-10-18T22:50:54Z", + "pushedDate": null, + "abbreviatedOid": "70d9fdb", + "oid": "70d9fdb8edd51c440d402b323c60ddbabf63b59b", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-10-09T16:30:00Z", + "committedDate": "2019-10-18T22:50:54Z", + "pushedDate": null, + "abbreviatedOid": "6451603", + "oid": "6451603e54acd1841b18b27187d24f5da07a5428", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/813d6fe0021b1437dcf408a39c34c54ac608ce9b/checks?check_suite_id=271785749", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/813d6fe0021b1437dcf408a39c34c54ac608ce9b/checks?check_suite_id=271785749", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/599887222?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-10T01:00:00Z", + "committedDate": "2019-10-18T22:50:54Z", + "pushedDate": "2019-10-18T22:51:19Z", + "abbreviatedOid": "813d6fe", + "oid": "813d6fe0021b1437dcf408a39c34c54ac608ce9b", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/b634ec7b05383b2bc8aa730c5a7a6e336c0af4b4/checks?check_suite_id=272146733", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b634ec7b05383b2bc8aa730c5a7a6e336c0af4b4/checks?check_suite_id=272146733", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/600015754?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-19T11:20:00Z", + "committedDate": "2019-10-19T11:19:33Z", + "pushedDate": "2019-10-19T11:19:22Z", + "abbreviatedOid": "b634ec7", + "oid": "b634ec7b05383b2bc8aa730c5a7a6e336c0af4b4", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/4e2290d0ac9388f6a0376721818f5bf046d122e5/checks?check_suite_id=272318377", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/4e2290d0ac9388f6a0376721818f5bf046d122e5/checks?check_suite_id=272318377", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/600095152?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-19T16:45:00Z", + "committedDate": "2019-10-19T16:48:31Z", + "pushedDate": "2019-10-19T16:48:50Z", + "abbreviatedOid": "4e2290d", + "oid": "4e2290d0ac9388f6a0376721818f5bf046d122e5", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/0e6e7f4d543b37e7862868499883a4afb3f59e5c/checks?check_suite_id=272389644", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0e6e7f4d543b37e7862868499883a4afb3f59e5c/checks?check_suite_id=272389644", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/600130297?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-19T19:00:00Z", + "committedDate": "2019-10-19T19:06:12Z", + "pushedDate": "2019-10-19T19:06:02Z", + "abbreviatedOid": "0e6e7f4", + "oid": "0e6e7f4d543b37e7862868499883a4afb3f59e5c", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/e40b41f143dd741340b23fe88184a42b881775e5/checks?check_suite_id=276777519", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/e40b41f143dd741340b23fe88184a42b881775e5/checks?check_suite_id=276777519", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/601529680?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-22T22:20:00Z", + "committedDate": "2019-10-22T22:21:56Z", + "pushedDate": "2019-10-22T22:21:42Z", + "abbreviatedOid": "e40b41f", + "oid": "e40b41f143dd741340b23fe88184a42b881775e5", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "CANCELLED", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/44403f972f64bf11ba9f1c724f8ad6505b4cf0eb/checks?check_suite_id=276806822", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/44403f972f64bf11ba9f1c724f8ad6505b4cf0eb/checks?check_suite_id=276806822", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/601540406?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-22T22:50:00Z", + "committedDate": "2019-10-22T22:50:15Z", + "pushedDate": "2019-10-22T22:49:56Z", + "abbreviatedOid": "44403f9", + "oid": "44403f972f64bf11ba9f1c724f8ad6505b4cf0eb", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "CANCELLED", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/f2c94a555651e7aa8a9f344c26caae3a3020377e/checks?check_suite_id=276809299", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/f2c94a555651e7aa8a9f344c26caae3a3020377e/checks?check_suite_id=276809299", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/601541095?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-22T22:52:03Z", + "committedDate": "2019-10-22T22:52:03Z", + "pushedDate": "2019-10-22T22:52:05Z", + "abbreviatedOid": "f2c94a5", + "oid": "f2c94a555651e7aa8a9f344c26caae3a3020377e", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/3aba5ac906488433b92621605ef1eaceff29679b/checks?check_suite_id=276813151", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3aba5ac906488433b92621605ef1eaceff29679b/checks?check_suite_id=276813151", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/601542258?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-10-22T22:55:00Z", + "committedDate": "2019-10-22T22:56:14Z", + "pushedDate": "2019-10-22T22:55:52Z", + "abbreviatedOid": "3aba5ac", + "oid": "3aba5ac906488433b92621605ef1eaceff29679b", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "CANCELLED", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/5a99874ff448082aeadcba0723cc8416fe7534cb/checks?check_suite_id=297546363", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5a99874ff448082aeadcba0723cc8416fe7534cb/checks?check_suite_id=297546363", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/607942118?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-06T00:00:00Z", + "committedDate": "2019-11-06T00:23:00Z", + "pushedDate": "2019-11-06T00:23:08Z", + "abbreviatedOid": "5a99874", + "oid": "5a99874ff448082aeadcba0723cc8416fe7534cb", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/f5fd25dd9379af21d7c01eec72e657d74a5d8e0c/checks?check_suite_id=297550993", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/f5fd25dd9379af21d7c01eec72e657d74a5d8e0c/checks?check_suite_id=297550993", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/607943349?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-06T00:15:00Z", + "committedDate": "2019-11-06T00:23:25Z", + "pushedDate": "2019-11-06T00:28:06Z", + "abbreviatedOid": "f5fd25d", + "oid": "f5fd25dd9379af21d7c01eec72e657d74a5d8e0c", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/f0cd302ecc80ac2cc4f2cd0db999c4dab6b5304c/checks?check_suite_id=297756777", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/f0cd302ecc80ac2cc4f2cd0db999c4dab6b5304c/checks?check_suite_id=297756777", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/608004514?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-06T04:30:00Z", + "committedDate": "2019-11-06T04:32:41Z", + "pushedDate": "2019-11-06T04:32:21Z", + "abbreviatedOid": "f0cd302", + "oid": "f0cd302ecc80ac2cc4f2cd0db999c4dab6b5304c", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/aa67527d028642223f41c7fe8ea12da62c274a8e/checks?check_suite_id=299365122", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/aa67527d028642223f41c7fe8ea12da62c274a8e/checks?check_suite_id=299365122", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/608474743?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-06T23:20:00Z", + "committedDate": "2019-11-06T23:22:19Z", + "pushedDate": "2019-11-06T23:22:12Z", + "abbreviatedOid": "aa67527", + "oid": "aa67527d028642223f41c7fe8ea12da62c274a8e", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/719b3f5b38290caf6b88a55d8894c228afb2d772/checks?check_suite_id=300279910", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/719b3f5b38290caf6b88a55d8894c228afb2d772/checks?check_suite_id=300279910", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/608736737?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-07T13:40:00Z", + "committedDate": "2019-11-07T13:35:47Z", + "pushedDate": "2019-11-07T13:40:20Z", + "abbreviatedOid": "719b3f5", + "oid": "719b3f5b38290caf6b88a55d8894c228afb2d772", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "CANCELLED", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/9d7b5b983c5b5e0a8ca344cf2af70bd8ad6ea5ec/checks?check_suite_id=302704861", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/9d7b5b983c5b5e0a8ca344cf2af70bd8ad6ea5ec/checks?check_suite_id=302704861", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/609413580?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-08T20:30:00Z", + "committedDate": "2019-11-08T20:56:06Z", + "pushedDate": "2019-11-08T20:55:48Z", + "abbreviatedOid": "9d7b5b9", + "oid": "9d7b5b983c5b5e0a8ca344cf2af70bd8ad6ea5ec", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/b4716bc3817ee2b38b9c3bc87eee49c033e0d4ed/checks?check_suite_id=302711560", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b4716bc3817ee2b38b9c3bc87eee49c033e0d4ed/checks?check_suite_id=302711560", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/609415396?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-08T21:00:00Z", + "committedDate": "2019-11-08T21:01:23Z", + "pushedDate": "2019-11-08T21:01:06Z", + "abbreviatedOid": "b4716bc", + "oid": "b4716bc3817ee2b38b9c3bc87eee49c033e0d4ed", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-11-09T21:30:00Z", + "committedDate": "2019-11-15T23:44:04Z", + "pushedDate": null, + "abbreviatedOid": "818f2a0", + "oid": "818f2a0623c2f40afac0952f7a7b8906a1324353", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [], + "__typename": "CheckSuiteConnection" + }, + "status": null, + "authoredDate": "2019-11-15T23:45:00Z", + "committedDate": "2019-11-16T00:47:00Z", + "pushedDate": null, + "abbreviatedOid": "a663913", + "oid": "a663913be284b6f8d23897cb433fc9c8c0be7629", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/3f2372fc8ea2626bbbe6c013b7c8f2676c5a8edf/checks?check_suite_id=313826891", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3f2372fc8ea2626bbbe6c013b7c8f2676c5a8edf/checks?check_suite_id=313826891", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/612655404?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-11-16T00:45:00Z", + "committedDate": "2019-11-16T00:48:00Z", + "pushedDate": "2019-11-16T00:48:39Z", + "abbreviatedOid": "3f2372f", + "oid": "3f2372fc8ea2626bbbe6c013b7c8f2676c5a8edf", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/0164b400a2ec441554cecbd6718a238d42fd80fc/checks?check_suite_id=379105709", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0164b400a2ec441554cecbd6718a238d42fd80fc/checks?check_suite_id=379105709", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/631093486?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2019-12-30T21:45:00Z", + "committedDate": "2019-12-30T21:47:34Z", + "pushedDate": "2019-12-30T21:46:51Z", + "abbreviatedOid": "0164b40", + "oid": "0164b400a2ec441554cecbd6718a238d42fd80fc", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + }, + { + "commit": { + "checkSuites": { + "nodes": [ + { + "app": { + "name": "Azure Pipelines", + "__typename": "App" + }, + "conclusion": "SUCCESS", + "resourcePath": "/DefinitelyTyped/DefinitelyTyped/commit/222334139e52fc16369464cfb5dc95c82f71192f/checks?check_suite_id=383650012", + "status": "COMPLETED", + "url": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/222334139e52fc16369464cfb5dc95c82f71192f/checks?check_suite_id=383650012", + "__typename": "CheckSuite" + } + ], + "__typename": "CheckSuiteConnection" + }, + "status": { + "state": "SUCCESS", + "contexts": [ + { + "state": "SUCCESS", + "description": "The Travis CI build passed", + "creator": { + "login": "borisyankov", + "__typename": "User" + }, + "targetUrl": "https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/632446617?utm_source=github_status&utm_medium=notification", + "__typename": "StatusContext" + } + ], + "__typename": "Status" + }, + "authoredDate": "2020-01-03T21:00:00Z", + "committedDate": "2020-01-03T21:03:00Z", + "pushedDate": "2020-01-03T21:02:41Z", + "abbreviatedOid": "2223341", + "oid": "222334139e52fc16369464cfb5dc95c82f71192f", + "__typename": "Commit" + }, + "__typename": "PullRequestCommit" + } + ], + "__typename": "PullRequestCommitConnection" + }, + "comments": { + "totalCount": 20, + "nodes": [ + { + "id": "MDEyOklzc3VlQ29tbWVudDUzOTY0MDI1OA==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "\r\n@ExE-Boss Thank you for submitting this PR!\n \nBecause this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.\n \nIn the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!\r\n", + "createdAt": "2019-10-08T18:22:32Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0MTk5NTIxNw==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "\r\nAfter 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!\r\n", + "createdAt": "2019-10-15T01:26:04Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0MzM3MDM4OA==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "\r\n@ExE-Boss One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!\r\n", + "createdAt": "2019-10-17T21:31:10Z", + "reactions": { + "nodes": [ + { + "user": { + "login": "ExE-Boss", + "__typename": "User" + }, + "__typename": "Reaction" + } + ], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0Mzk5Njg3NQ==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "\n\n👋 **Hi there!** I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.\n\n\nLet’s review the numbers, shall we?\n\nThese typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to es-abstract with its source on master.\n\n\n
\nComparison details 📊\n\n| **Batch compilation** | |\n| ----------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- |\n| Type count | 4493 |\n| Assignability cache size | 925 |\n| | |\n| **Language service measurements** | |\n| Samples taken | 910 |\n| Identifiers in tests | 910 |\n| **`getCompletionsAtPosition`** | |\n|     Mean duration (ms) | 125.1 |\n|     Mean [CV](https://en.wikipedia.org/wiki/Coefficient_of_variation) | 15.4% |\n|     Worst duration (ms) | 202.9 |\n|     Worst identifier | [CheckObjectCoercible](/DefinitelyTyped/DefinitelyTyped/blob/cdd01901cad98ae8fd150bfc5c51907d51abe6a2/types/es-abstract/test/es5.test.ts#L39) |\n| **`getQuickInfoAtPosition`** | |\n|     Mean duration (ms) | 125.8 |\n|     Mean [CV](https://en.wikipedia.org/wiki/Coefficient_of_variation) | 17.5% |\n|     Worst duration (ms) | 191.2 |\n|     Worst identifier | [Call](/DefinitelyTyped/DefinitelyTyped/blob/cdd01901cad98ae8fd150bfc5c51907d51abe6a2/types/es-abstract/test/es2015.test.ts#L12) |\n| | |\n| **System information** | |\n| Node version | v10.16.3 |\n| CPU count | 2 |\n| CPU speed | 2.294 GHz |\n| CPU model | Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz |\n| CPU Architecture | x64 |\n| Memory | 6.8 GiB |\n| Platform | linux |\n| Release | 4.15.0-1059-azure |\n\n\n
\n", + "createdAt": "2019-10-18T23:06:50Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0NDE1MzI5Mw==", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "body": "needinfo?(@ljharb): Should I also add types for utilities in the `helpers` directory?", + "createdAt": "2019-10-19T14:41:07Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0NDE1OTkwOA==", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "body": "everything reachable is part of the public api, so probably yes.", + "createdAt": "2019-10-19T15:26:36Z", + "reactions": { + "nodes": [ + { + "user": { + "login": "ExE-Boss", + "__typename": "User" + }, + "__typename": "Reaction" + } + ], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0NTE2Nzc5Mg==", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "body": "review?(@ljharb): I have now added type definitions for all reachable files.", + "createdAt": "2019-10-22T21:39:56Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU0NTE4NDEyMw==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "\r\n🔔 @weswigham - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?\r\n", + "createdAt": "2019-10-22T22:31:54Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU1MTA4MzEzNQ==", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "body": "These types are still very much a work in progress.", + "createdAt": "2019-11-07T13:40:31Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU1MTA4ODE3NQ==", + "author": { + "login": "ExE-Boss", + "__typename": "User" + }, + "body": "Also, it’s likely that I’ll soon have to update this to v2.0 because of https://github.com/ljharb/es-abstract/issues/62, https://github.com/ljharb/es-abstract/issues/66, https://github.com/ljharb/es-abstract/pull/67, https://github.com/ljharb/es-abstract/pull/68 and https://github.com/ljharb/es-abstract/pull/69.", + "createdAt": "2019-11-07T13:53:10Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDU2OTgwNzIzMg==", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "body": "I wouldn't wait for v2; it'd be more useful to get v1.17 out.", + "createdAt": "2019-12-30T21:53:58Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@ExE-Boss Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n- [es-abstract on npm](https://www.npmjs.com/package/es-abstract)\n - [es-abstract on unpkg](https://unpkg.com/browse/es-abstract@latest//)\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 38979,\n \"author\": \"ExE-Boss\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"2223341\",\n \"headCommitOid\": \"222334139e52fc16369464cfb5dc95c82f71192f\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 129,\n \"lastCommitDate\": \"2020-01-03T21:02:41.000Z\",\n \"reopenedDate\": \"2019-10-18T22:52:06.000Z\",\n \"lastCommentDate\": \"2020-05-12T15:13:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": true,\n \"packages\": [\n \"es-abstract\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/es-abstract/GetIntrinsic.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es5.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es6.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es7.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assertRecord.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBind.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBound.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/every.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/forEach.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getInferredName.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getIteratorMethod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getSymbolDescription.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isFinite.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isNaN.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrefixOf.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrimitive.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isSamePropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/maxSafeInteger.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/mod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/regexTester.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/setProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/sign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/GetIntrinsic.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es5.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assertRecord.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBind.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBound.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/every.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/forEach.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getInferredName.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getIteratorMethod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getSymbolDescription.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isFinite.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isNaN.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrefixOf.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrimitive.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isSamePropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/maxSafeInteger.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/mod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/regexTester.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/setProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/sign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/index.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n }\n ],\n \"hasDismissedReview\": true,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-05-12T04:51:52.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"3aba5ac\",\n \"reviewer\": \"sandersn\"\n },\n {\n \"reviewedAbbrOid\": \"0e6e7f4\",\n \"reviewer\": \"weswigham\"\n }\n ],\n \"approvalFlags\": 1,\n \"isChangesRequested\": false\n}\n```\n\n
\n", + "createdAt": "2020-05-12T04:12:41Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxNw==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-05-12T04:12:42Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAyMg==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-05-12T04:12:43Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAyNw==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-05-12T04:12:43Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAzMQ==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-05-12T04:12:44Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAzMg==", + "author": { + "login": "typescript-bot", + "__typename": "User" + }, + "body": "@ljharb Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n", + "createdAt": "2020-05-12T04:12:45Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzEwNjI1Ng==", + "author": { + "login": "ljharb", + "__typename": "User" + }, + "body": "… why do i need 3 pings", + "createdAt": "2020-05-12T04:51:03Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzQwNzIzOA==", + "author": { + "login": "sandersn", + "__typename": "User" + }, + "body": "@ljharb the bot is now running asynchrono\r\n@orta you wanted to know about bad behaviour like this I think.\r\nusly!", + "createdAt": "2020-05-12T15:11:44Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + }, + { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzQwODIxMg==", + "author": { + "login": "orta", + "__typename": "User" + }, + "body": "Thanks, that is definitely suspicious", + "createdAt": "2020-05-12T15:13:19Z", + "reactions": { + "nodes": [], + "__typename": "ReactionConnection" + }, + "__typename": "IssueComment" + } + ], + "__typename": "IssueCommentConnection" + }, + "files": { + "nodes": [ + { + "path": "types/es-abstract/GetIntrinsic.d.ts", + "additions": 138, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es2015.d.ts", + "additions": 234, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es2016.d.ts", + "additions": 36, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es2017.d.ts", + "additions": 42, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es2018.d.ts", + "additions": 47, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es2019.d.ts", + "additions": 63, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es5.d.ts", + "additions": 88, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es6.d.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/es7.d.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/assertRecord.d.ts", + "additions": 21, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/assign.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/callBind.d.ts", + "additions": 137, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/callBound.d.ts", + "additions": 21, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/every.d.ts", + "additions": 5, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/forEach.d.ts", + "additions": 12, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/getInferredName.d.ts", + "additions": 9, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/getIteratorMethod.d.ts", + "additions": 12, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/getProto.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/getSymbolDescription.d.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isFinite.d.ts", + "additions": 1, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isNaN.d.ts", + "additions": 1, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isPrefixOf.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isPrimitive.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isPropertyDescriptor.d.ts", + "additions": 16, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/isSamePropertyDescriptor.d.ts", + "additions": 9, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/maxSafeInteger.d.ts", + "additions": 1, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/mod.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/regexTester.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/setProto.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/helpers/sign.d.ts", + "additions": 2, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/index.d.ts", + "additions": 56, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/operations/2015.d.ts", + "additions": 13, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/operations/2016.d.ts", + "additions": 164, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/operations/2017.d.ts", + "additions": 58, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/operations/2018.d.ts", + "additions": 43, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/operations/2019.d.ts", + "additions": 15, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/GetIntrinsic.test.ts", + "additions": 451, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es2015.test.ts", + "additions": 108, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es2016.test.ts", + "additions": 21, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es2017.test.ts", + "additions": 36, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es2018.test.ts", + "additions": 19, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es2019.test.ts", + "additions": 17, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/es5.test.ts", + "additions": 53, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/assertRecord.test.ts", + "additions": 10, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/assign.test.ts", + "additions": 4, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/callBind.test.ts", + "additions": 12, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/callBound.test.ts", + "additions": 15, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/every.test.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/forEach.test.ts", + "additions": 22, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/getInferredName.test.ts", + "additions": 9, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/getIteratorMethod.test.ts", + "additions": 15, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/getProto.test.ts", + "additions": 7, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/getSymbolDescription.test.ts", + "additions": 4, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isFinite.test.ts", + "additions": 5, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isNaN.test.ts", + "additions": 5, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isPrefixOf.test.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isPrimitive.test.ts", + "additions": 9, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isPropertyDescriptor.test.ts", + "additions": 8, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/isSamePropertyDescriptor.test.ts", + "additions": 8, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/maxSafeInteger.test.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/mod.test.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/regexTester.test.ts", + "additions": 4, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/setProto.test.ts", + "additions": 10, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/helpers/sign.test.ts", + "additions": 3, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/index.test.ts", + "additions": 36, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/operations/2015.test.ts", + "additions": 234, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/operations/2016.test.ts", + "additions": 477, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/operations/2017.test.ts", + "additions": 413, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/operations/2018.test.ts", + "additions": 432, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/test/operations/2019.test.ts", + "additions": 402, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/tsconfig.json", + "additions": 52, + "deletions": 0, + "__typename": "PullRequestChangedFile" + }, + { + "path": "types/es-abstract/tslint.json", + "additions": 1, + "deletions": 0, + "__typename": "PullRequestChangedFile" + } + ], + "__typename": "PullRequestChangedFileConnection" + }, + "projectCards": { + "nodes": [ + { + "id": "MDExOlByb2plY3RDYXJkMjc1MTM1NTA=", + "project": { + "id": "MDc6UHJvamVjdDE0NDQ5NTY=", + "number": 4, + "name": "Pull Request Status Board", + "__typename": "Project" + }, + "column": { + "id": "MDEzOlByb2plY3RDb2x1bW4yNTYxMzU5", + "name": "Needs Author Attention", + "__typename": "ProjectColumn" + }, + "__typename": "ProjectCard" + } + ], + "__typename": "ProjectCardConnection" + }, + "__typename": "PullRequest" + }, + "__typename": "Repository" + } + }, + "loading": false, + "networkStatus": 7, + "stale": false +} diff --git a/src/_tests/fixtures/38979/derived.json b/src/_tests/fixtures/38979/derived.json new file mode 100644 index 000000000..1bd501278 --- /dev/null +++ b/src/_tests/fixtures/38979/derived.json @@ -0,0 +1,405 @@ +{ + "type": "info", + "now": "2020-05-12T19:14:42.000Z", + "pr_number": 38979, + "author": "ExE-Boss", + "owners": [ + "RReverser" + ], + "dangerLevel": "ScopedAndConfiguration", + "headCommitAbbrOid": "2223341", + "headCommitOid": "222334139e52fc16369464cfb5dc95c82f71192f", + "mergeIsRequested": false, + "stalenessInDays": 129, + "lastCommitDate": "2020-01-03T21:02:41.000Z", + "reopenedDate": "2019-10-18T22:52:06.000Z", + "lastCommentDate": "2020-05-12T15:13:19.000Z", + "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files", + "hasMergeConflict": false, + "authorIsOwner": false, + "isFirstContribution": false, + "popularityLevel": "Critical", + "anyPackageIsNew": false, + "packages": [ + "es-abstract" + ], + "files": [ + { + "filePath": "types/es-abstract/GetIntrinsic.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es2015.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es2016.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es2017.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es2018.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es2019.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es5.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es6.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/es7.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/assertRecord.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/assign.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/callBind.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/callBound.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/every.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/forEach.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/getInferredName.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/getIteratorMethod.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/getProto.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/getSymbolDescription.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isFinite.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isNaN.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isPrefixOf.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isPrimitive.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isPropertyDescriptor.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/isSamePropertyDescriptor.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/maxSafeInteger.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/mod.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/regexTester.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/setProto.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/helpers/sign.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/index.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/operations/2015.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/operations/2016.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/operations/2017.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/operations/2018.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/operations/2019.d.ts", + "kind": "definition", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/GetIntrinsic.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es2015.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es2016.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es2017.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es2018.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es2019.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/es5.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/assertRecord.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/assign.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/callBind.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/callBound.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/every.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/forEach.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/getInferredName.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/getIteratorMethod.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/getProto.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/getSymbolDescription.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isFinite.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isNaN.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isPrefixOf.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isPrimitive.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isPropertyDescriptor.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/isSamePropertyDescriptor.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/maxSafeInteger.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/mod.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/regexTester.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/setProto.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/helpers/sign.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/index.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/operations/2015.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/operations/2016.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/operations/2017.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/operations/2018.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/test/operations/2019.test.ts", + "kind": "test", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/tsconfig.json", + "kind": "package-meta", + "package": "es-abstract" + }, + { + "filePath": "types/es-abstract/tslint.json", + "kind": "package-meta", + "package": "es-abstract" + } + ], + "hasDismissedReview": true, + "travisResult": "pass", + "lastReviewDate": "2020-05-12T04:51:52.000Z", + "reviewersWithStaleReviews": [ + { + "reviewedAbbrOid": "3aba5ac", + "reviewer": "sandersn", + "date": "2019-10-22T22:56:09Z" + }, + { + "reviewedAbbrOid": "0e6e7f4", + "reviewer": "weswigham", + "date": "2019-10-22T21:43:25Z" + } + ], + "approvalFlags": 1, + "isChangesRequested": false +} \ No newline at end of file diff --git a/src/_tests/fixtures/38979/mutations.json b/src/_tests/fixtures/38979/mutations.json new file mode 100644 index 000000000..6afea06bb --- /dev/null +++ b/src/_tests/fixtures/38979/mutations.json @@ -0,0 +1,60 @@ +[ + { + "query": "mutation($input: AddLabelsToLabelableInput!) { addLabelsToLabelable(input: $input) { clientMutationId } }", + "variables": { + "input": { + "labelIds": [ + "MDU6TGFiZWwxNjA4NjM0NDg0" + ], + "labelableId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0" + } + } + }, + { + "query": "mutation($input: RemoveLabelsFromLabelableInput!) { removeLabelsFromLabelable(input: $input) { clientMutationId } }", + "variables": { + "input": { + "labelIds": [ + "MDU6TGFiZWw2NDY3ODg4ODg=" + ], + "labelableId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0" + } + } + }, + { + "query": "mutation($input: AddProjectCardInput!) { addProjectCard(input: $input) { clientMutationId } }", + "variables": { + "input": { + "contentId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "projectColumnId": "MDEzOlByb2plY3RDb2x1bW43NTUyOTIy" + } + } + }, + { + "query": "mutation($input: UpdateIssueCommentInput!) { updateIssueComment(input: $input) { clientMutationId } }", + "variables": { + "input": { + "id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==", + "body": "@ExE-Boss Thank you for submitting this PR! \n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to merge changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 38979,\n \"author\": \"ExE-Boss\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"2223341\",\n \"headCommitOid\": \"222334139e52fc16369464cfb5dc95c82f71192f\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 129,\n \"lastCommitDate\": \"2020-01-03T21:02:41.000Z\",\n \"reopenedDate\": \"2019-10-18T22:52:06.000Z\",\n \"lastCommentDate\": \"2020-05-12T15:13:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"es-abstract\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/es-abstract/GetIntrinsic.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es5.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es6.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es7.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assertRecord.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBind.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBound.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/every.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/forEach.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getInferredName.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getIteratorMethod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getSymbolDescription.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isFinite.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isNaN.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrefixOf.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrimitive.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isSamePropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/maxSafeInteger.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/mod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/regexTester.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/setProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/sign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/GetIntrinsic.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es5.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assertRecord.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBind.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBound.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/every.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/forEach.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getInferredName.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getIteratorMethod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getSymbolDescription.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isFinite.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isNaN.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrefixOf.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrimitive.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isSamePropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/maxSafeInteger.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/mod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/regexTester.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/setProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/sign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/index.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n }\n ],\n \"hasDismissedReview\": true,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-05-12T04:51:52.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"3aba5ac\",\n \"reviewer\": \"sandersn\",\n \"date\": \"2019-10-22T22:56:09Z\"\n },\n {\n \"reviewedAbbrOid\": \"0e6e7f4\",\n \"reviewer\": \"weswigham\",\n \"date\": \"2019-10-22T21:43:25Z\"\n }\n ],\n \"approvalFlags\": 1,\n \"isChangesRequested\": false\n}\n```\n\n
\n" + } + } + }, + { + "query": "mutation($input: AddCommentInput!) { addComment(input: $input) { clientMutationId } }", + "variables": { + "input": { + "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "body": "🔔 @RReverser - please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on.\n" + } + } + }, + { + "query": "mutation($input: AddCommentInput!) { addComment(input: $input) { clientMutationId } }", + "variables": { + "input": { + "subjectId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0", + "body": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + } + } + } +] \ No newline at end of file diff --git a/src/_tests/fixtures/38979/result.json b/src/_tests/fixtures/38979/result.json new file mode 100644 index 000000000..fcd975743 --- /dev/null +++ b/src/_tests/fixtures/38979/result.json @@ -0,0 +1,41 @@ +{ + "pr_number": 38979, + "targetColumn": "Needs Maintainer Review", + "labels": { + "Has Merge Conflict": false, + "The Travis CI build failed": false, + "Revision needed": false, + "New Definition": false, + "Where is Travis?": false, + "Owner Approved": false, + "Other Approved": true, + "Maintainer Approved": false, + "Merge:LGTM": false, + "Merge:YSYL": false, + "Popular package": false, + "Critical package": true, + "Edits Infrastructure": false, + "Edits multiple packages": false, + "Author is Owner": false, + "Merge:Auto": false + }, + "responseComments": [ + { + "tag": "welcome", + "status": "@ExE-Boss Thank you for submitting this PR! \n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to merge changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 38979,\n \"author\": \"ExE-Boss\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"2223341\",\n \"headCommitOid\": \"222334139e52fc16369464cfb5dc95c82f71192f\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 129,\n \"lastCommitDate\": \"2020-01-03T21:02:41.000Z\",\n \"reopenedDate\": \"2019-10-18T22:52:06.000Z\",\n \"lastCommentDate\": \"2020-05-12T15:13:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"es-abstract\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/es-abstract/GetIntrinsic.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es5.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es6.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/es7.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assertRecord.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/assign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBind.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/callBound.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/every.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/forEach.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getInferredName.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getIteratorMethod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/getSymbolDescription.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isFinite.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isNaN.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrefixOf.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPrimitive.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isPropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/isSamePropertyDescriptor.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/maxSafeInteger.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/mod.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/regexTester.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/setProto.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/helpers/sign.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2015.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2016.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2017.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2018.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/operations/2019.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/GetIntrinsic.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/es5.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assertRecord.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/assign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBind.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/callBound.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/every.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/forEach.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getInferredName.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getIteratorMethod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/getSymbolDescription.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isFinite.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isNaN.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrefixOf.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPrimitive.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isPropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/isSamePropertyDescriptor.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/maxSafeInteger.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/mod.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/regexTester.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/setProto.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/helpers/sign.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/index.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2015.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2016.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2017.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2018.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/test/operations/2019.test.ts\",\n \"kind\": \"test\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n },\n {\n \"filePath\": \"types/es-abstract/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"es-abstract\"\n }\n ],\n \"hasDismissedReview\": true,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-05-12T04:51:52.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"3aba5ac\",\n \"reviewer\": \"sandersn\",\n \"date\": \"2019-10-22T22:56:09Z\"\n },\n {\n \"reviewedAbbrOid\": \"0e6e7f4\",\n \"reviewer\": \"weswigham\",\n \"date\": \"2019-10-22T21:43:25Z\"\n }\n ],\n \"approvalFlags\": 1,\n \"isChangesRequested\": false\n}\n```\n\n
" + }, + { + "tag": "pinging-reviewers", + "status": "🔔 @RReverser - please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on." + }, + { + "tag": "stale-ping-764528-0e6e7f4", + "status": "@sandersn, @weswigham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" + } + ], + "shouldClose": false, + "shouldMerge": false, + "shouldUpdateLabels": true, + "shouldUpdateProjectColumn": true, + "shouldRemoveFromActiveColumns": false +} \ No newline at end of file diff --git a/src/_tests/fixtures/43136/derived.json b/src/_tests/fixtures/43136/derived.json index 3388afd8d..2183e040d 100644 --- a/src/_tests/fixtures/43136/derived.json +++ b/src/_tests/fixtures/43136/derived.json @@ -39,7 +39,8 @@ "reviewersWithStaleReviews": [ { "reviewedAbbrOid": "37d784d", - "reviewer": "RReverser" + "reviewer": "RReverser", + "date": "2020-03-14T19:22:34Z" } ], "approvalFlags": 0, diff --git a/src/_tests/fixtures/43136/mutations.json b/src/_tests/fixtures/43136/mutations.json index 990788ce8..e6f70e84b 100644 --- a/src/_tests/fixtures/43136/mutations.json +++ b/src/_tests/fixtures/43136/mutations.json @@ -36,7 +36,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4MzgyMzYy", - "body": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Most recent commit is approved by DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43136,\n \"author\": \"larsrh\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndTested\",\n \"headCommitAbbrOid\": \"e686353\",\n \"headCommitOid\": \"e6863537248bbfee8f0ef8c636bb00c25cf40b96\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 3,\n \"lastCommitDate\": \"2020-03-16T14:26:42.000Z\",\n \"lastCommentDate\": \"2020-03-16T14:26:42.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"estree\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/estree/estree-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"estree\"\n },\n {\n \"filePath\": \"types/estree/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"estree\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"37d784d\",\n \"reviewer\": \"RReverser\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" + "body": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Most recent commit is approved by DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43136,\n \"author\": \"larsrh\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndTested\",\n \"headCommitAbbrOid\": \"e686353\",\n \"headCommitOid\": \"e6863537248bbfee8f0ef8c636bb00c25cf40b96\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 3,\n \"lastCommitDate\": \"2020-03-16T14:26:42.000Z\",\n \"lastCommentDate\": \"2020-03-16T14:26:42.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"estree\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/estree/estree-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"estree\"\n },\n {\n \"filePath\": \"types/estree/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"estree\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"37d784d\",\n \"reviewer\": \"RReverser\",\n \"date\": \"2020-03-14T19:22:34Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" } } }, diff --git a/src/_tests/fixtures/43136/result.json b/src/_tests/fixtures/43136/result.json index 0b2c3bdfd..757ab4bb3 100644 --- a/src/_tests/fixtures/43136/result.json +++ b/src/_tests/fixtures/43136/result.json @@ -22,7 +22,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Most recent commit is approved by DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43136,\n \"author\": \"larsrh\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndTested\",\n \"headCommitAbbrOid\": \"e686353\",\n \"headCommitOid\": \"e6863537248bbfee8f0ef8c636bb00c25cf40b96\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 3,\n \"lastCommitDate\": \"2020-03-16T14:26:42.000Z\",\n \"lastCommentDate\": \"2020-03-16T14:26:42.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"estree\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/estree/estree-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"estree\"\n },\n {\n \"filePath\": \"types/estree/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"estree\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"37d784d\",\n \"reviewer\": \"RReverser\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" + "status": "@larsrh Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Most recent commit is approved by DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43136,\n \"author\": \"larsrh\",\n \"owners\": [\n \"RReverser\"\n ],\n \"dangerLevel\": \"ScopedAndTested\",\n \"headCommitAbbrOid\": \"e686353\",\n \"headCommitOid\": \"e6863537248bbfee8f0ef8c636bb00c25cf40b96\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 3,\n \"lastCommitDate\": \"2020-03-16T14:26:42.000Z\",\n \"lastCommentDate\": \"2020-03-16T14:26:42.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43136/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Critical\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"estree\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/estree/estree-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"estree\"\n },\n {\n \"filePath\": \"types/estree/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"estree\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"37d784d\",\n \"reviewer\": \"RReverser\",\n \"date\": \"2020-03-14T19:22:34Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/43175/derived.json b/src/_tests/fixtures/43175/derived.json index a644a522d..58c962805 100644 --- a/src/_tests/fixtures/43175/derived.json +++ b/src/_tests/fixtures/43175/derived.json @@ -43,7 +43,8 @@ "reviewersWithStaleReviews": [ { "reviewedAbbrOid": "767a750", - "reviewer": "couven92" + "reviewer": "couven92", + "date": "2020-03-17T13:29:17Z" } ], "approvalFlags": 0, diff --git a/src/_tests/fixtures/43175/mutations.json b/src/_tests/fixtures/43175/mutations.json index ba2b5439d..09327cced 100644 --- a/src/_tests/fixtures/43175/mutations.json +++ b/src/_tests/fixtures/43175/mutations.json @@ -13,7 +13,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg5NzQ2Mjcx", - "body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43175,\n \"author\": \"ankhler\",\n \"owners\": [\n \"matthewkimber\",\n \"otiai10\",\n \"couven92\",\n \"rreverser\",\n \"sreimer15\",\n \"MatCarlson\",\n \"ekinsol\",\n \"tregagnon\",\n \"echoabstract\",\n \"spasma\"\n ],\n \"dangerLevel\": \"ScopedAndUntested\",\n \"headCommitAbbrOid\": \"b4b3bc8\",\n \"headCommitOid\": \"b4b3bc8a617e2e0810d60e389415818d903e6362\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 2,\n \"lastCommitDate\": \"2020-03-17T13:51:37.000Z\",\n \"lastCommentDate\": \"2020-03-17T13:51:37.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Popular\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"chrome\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/chrome/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"chrome\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"767a750\",\n \"reviewer\": \"couven92\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" + "body": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43175,\n \"author\": \"ankhler\",\n \"owners\": [\n \"matthewkimber\",\n \"otiai10\",\n \"couven92\",\n \"rreverser\",\n \"sreimer15\",\n \"MatCarlson\",\n \"ekinsol\",\n \"tregagnon\",\n \"echoabstract\",\n \"spasma\"\n ],\n \"dangerLevel\": \"ScopedAndUntested\",\n \"headCommitAbbrOid\": \"b4b3bc8\",\n \"headCommitOid\": \"b4b3bc8a617e2e0810d60e389415818d903e6362\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 2,\n \"lastCommitDate\": \"2020-03-17T13:51:37.000Z\",\n \"lastCommentDate\": \"2020-03-17T13:51:37.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Popular\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"chrome\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/chrome/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"chrome\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"767a750\",\n \"reviewer\": \"couven92\",\n \"date\": \"2020-03-17T13:29:17Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" } } }, diff --git a/src/_tests/fixtures/43175/result.json b/src/_tests/fixtures/43175/result.json index 21aee5949..2dd915ad8 100644 --- a/src/_tests/fixtures/43175/result.json +++ b/src/_tests/fixtures/43175/result.json @@ -22,7 +22,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43175,\n \"author\": \"ankhler\",\n \"owners\": [\n \"matthewkimber\",\n \"otiai10\",\n \"couven92\",\n \"rreverser\",\n \"sreimer15\",\n \"MatCarlson\",\n \"ekinsol\",\n \"tregagnon\",\n \"echoabstract\",\n \"spasma\"\n ],\n \"dangerLevel\": \"ScopedAndUntested\",\n \"headCommitAbbrOid\": \"b4b3bc8\",\n \"headCommitOid\": \"b4b3bc8a617e2e0810d60e389415818d903e6362\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 2,\n \"lastCommitDate\": \"2020-03-17T13:51:37.000Z\",\n \"lastCommentDate\": \"2020-03-17T13:51:37.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Popular\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"chrome\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/chrome/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"chrome\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"767a750\",\n \"reviewer\": \"couven92\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" + "status": "@ankhler Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.\n\n This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered [adding tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package) to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#editing-tests-on-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43175,\n \"author\": \"ankhler\",\n \"owners\": [\n \"matthewkimber\",\n \"otiai10\",\n \"couven92\",\n \"rreverser\",\n \"sreimer15\",\n \"MatCarlson\",\n \"ekinsol\",\n \"tregagnon\",\n \"echoabstract\",\n \"spasma\"\n ],\n \"dangerLevel\": \"ScopedAndUntested\",\n \"headCommitAbbrOid\": \"b4b3bc8\",\n \"headCommitOid\": \"b4b3bc8a617e2e0810d60e389415818d903e6362\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 2,\n \"lastCommitDate\": \"2020-03-17T13:51:37.000Z\",\n \"lastCommentDate\": \"2020-03-17T13:51:37.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43175/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": true,\n \"popularityLevel\": \"Popular\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"chrome\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/chrome/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"chrome\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"767a750\",\n \"reviewer\": \"couven92\",\n \"date\": \"2020-03-17T13:29:17Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" }, { "tag": "pinging-reviewers", diff --git a/src/_tests/fixtures/43695-duplicate-comment/derived.json b/src/_tests/fixtures/43695-duplicate-comment/derived.json index b11981f54..625691410 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/derived.json +++ b/src/_tests/fixtures/43695-duplicate-comment/derived.json @@ -48,15 +48,18 @@ "reviewersWithStaleReviews": [ { "reviewedAbbrOid": "68463fd", - "reviewer": "andrewbranch" + "reviewer": "andrewbranch", + "date": "2020-04-30T23:58:31Z" }, { "reviewedAbbrOid": "90c94f9", - "reviewer": "andrewbranch" + "reviewer": "andrewbranch", + "date": "2020-04-30T23:07:49Z" }, { "reviewedAbbrOid": "a5285cd", - "reviewer": "RyanCavanaugh" + "reviewer": "RyanCavanaugh", + "date": "2020-04-08T16:23:52Z" } ], "approvalFlags": 0, diff --git a/src/_tests/fixtures/43695-duplicate-comment/mutations.json b/src/_tests/fixtures/43695-duplicate-comment/mutations.json index 99f8de0b8..31779eb69 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/mutations.json +++ b/src/_tests/fixtures/43695-duplicate-comment/mutations.json @@ -24,7 +24,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"3e83617\",\n \"headCommitOid\": \"3e836178b736e5512361ffda46e84a5c668d7a90\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": null,\n \"lastCommitDate\": \"1970-01-01T00:00:00.000Z\",\n \"reopenedDate\": \"2020-04-30T23:08:16.000Z\",\n \"lastCommentDate\": \"2020-05-01T00:19:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"68463fd\",\n \"reviewer\": \"andrewbranch\"\n },\n {\n \"reviewedAbbrOid\": \"90c94f9\",\n \"reviewer\": \"andrewbranch\"\n },\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" + "body": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"3e83617\",\n \"headCommitOid\": \"3e836178b736e5512361ffda46e84a5c668d7a90\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": null,\n \"lastCommitDate\": \"1970-01-01T00:00:00.000Z\",\n \"reopenedDate\": \"2020-04-30T23:08:16.000Z\",\n \"lastCommentDate\": \"2020-05-01T00:19:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"68463fd\",\n \"reviewer\": \"andrewbranch\",\n \"date\": \"2020-04-30T23:58:31Z\"\n },\n {\n \"reviewedAbbrOid\": \"90c94f9\",\n \"reviewer\": \"andrewbranch\",\n \"date\": \"2020-04-30T23:07:49Z\"\n },\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\",\n \"date\": \"2020-04-08T16:23:52Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
\n" } } }, @@ -33,16 +33,7 @@ "variables": { "input": { "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", - "body": "@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" - } - } - }, - { - "query": "mutation($input: AddCommentInput!) { addComment(input: $input) { clientMutationId } }", - "variables": { - "input": { - "subjectId": "MDExOlB1bGxSZXF1ZXN0NDAwMTAwMTk2", - "body": "@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" + "body": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?\n" } } } diff --git a/src/_tests/fixtures/43695-duplicate-comment/result.json b/src/_tests/fixtures/43695-duplicate-comment/result.json index 6dd209696..54708835e 100644 --- a/src/_tests/fixtures/43695-duplicate-comment/result.json +++ b/src/_tests/fixtures/43695-duplicate-comment/result.json @@ -22,19 +22,11 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"3e83617\",\n \"headCommitOid\": \"3e836178b736e5512361ffda46e84a5c668d7a90\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": null,\n \"lastCommitDate\": \"1970-01-01T00:00:00.000Z\",\n \"reopenedDate\": \"2020-04-30T23:08:16.000Z\",\n \"lastCommentDate\": \"2020-05-01T00:19:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"68463fd\",\n \"reviewer\": \"andrewbranch\"\n },\n {\n \"reviewedAbbrOid\": \"90c94f9\",\n \"reviewer\": \"andrewbranch\"\n },\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" + "status": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThere aren't any other owners of this package, so a DT maintainer will review it.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer can merge changes when there are no other reviewers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"3e83617\",\n \"headCommitOid\": \"3e836178b736e5512361ffda46e84a5c668d7a90\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": null,\n \"lastCommitDate\": \"1970-01-01T00:00:00.000Z\",\n \"reopenedDate\": \"2020-04-30T23:08:16.000Z\",\n \"lastCommentDate\": \"2020-05-01T00:19:19.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": false,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"68463fd\",\n \"reviewer\": \"andrewbranch\",\n \"date\": \"2020-04-30T23:58:31Z\"\n },\n {\n \"reviewedAbbrOid\": \"90c94f9\",\n \"reviewer\": \"andrewbranch\",\n \"date\": \"2020-04-30T23:07:49Z\"\n },\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\",\n \"date\": \"2020-04-08T16:23:52Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": false\n}\n```\n\n
" }, { - "tag": "stale-ping-b0edd0-68463fd", - "status": "@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" - }, - { - "tag": "stale-ping-b0edd0-90c94f9", - "status": "@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" - }, - { - "tag": "stale-ping-fbf110-a5285cd", - "status": "@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" + "tag": "stale-ping-61f252-a5285cd", + "status": "@andrewbranch, @RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?" } ], "shouldClose": false, diff --git a/src/_tests/fixtures/43695-post-review/derived.json b/src/_tests/fixtures/43695-post-review/derived.json index c76e2701c..7d488d2e2 100644 --- a/src/_tests/fixtures/43695-post-review/derived.json +++ b/src/_tests/fixtures/43695-post-review/derived.json @@ -48,7 +48,8 @@ "reviewersWithStaleReviews": [ { "reviewedAbbrOid": "a5285cd", - "reviewer": "RyanCavanaugh" + "reviewer": "RyanCavanaugh", + "date": "2020-04-08T16:23:52Z" } ], "approvalFlags": 0, diff --git a/src/_tests/fixtures/43695-post-review/mutations.json b/src/_tests/fixtures/43695-post-review/mutations.json index 272b42eec..bb47b76c1 100644 --- a/src/_tests/fixtures/43695-post-review/mutations.json +++ b/src/_tests/fixtures/43695-post-review/mutations.json @@ -13,7 +13,7 @@ "variables": { "input": { "id": "MDEyOklzc3VlQ29tbWVudDYxMDIzNDI3MA==", - "body": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n- [accedo__accedo-one on npm](https://www.npmjs.com/package/accedo__accedo-one)\n - [accedo__accedo-one on unpkg](https://unpkg.com/browse/accedo__accedo-one@latest//)\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"90c94f9\",\n \"headCommitOid\": \"90c94f91120c026f5f8bcc586426e8590b7b4048\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 15,\n \"lastCommitDate\": \"2020-04-15T15:53:29.000Z\",\n \"lastCommentDate\": \"2020-04-30T23:07:44.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": true,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-04-30T23:07:49.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": true\n}\n```\n\n
\n" + "body": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n- [accedo__accedo-one on npm](https://www.npmjs.com/package/accedo__accedo-one)\n - [accedo__accedo-one on unpkg](https://unpkg.com/browse/accedo__accedo-one@latest//)\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"90c94f9\",\n \"headCommitOid\": \"90c94f91120c026f5f8bcc586426e8590b7b4048\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 15,\n \"lastCommitDate\": \"2020-04-15T15:53:29.000Z\",\n \"lastCommentDate\": \"2020-04-30T23:07:44.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": true,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-04-30T23:07:49.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\",\n \"date\": \"2020-04-08T16:23:52Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": true\n}\n```\n\n
\n" } } }, diff --git a/src/_tests/fixtures/43695-post-review/result.json b/src/_tests/fixtures/43695-post-review/result.json index 13c7ddd71..e141f89a8 100644 --- a/src/_tests/fixtures/43695-post-review/result.json +++ b/src/_tests/fixtures/43695-post-review/result.json @@ -22,7 +22,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n- [accedo__accedo-one on npm](https://www.npmjs.com/package/accedo__accedo-one)\n - [accedo__accedo-one on unpkg](https://unpkg.com/browse/accedo__accedo-one@latest//)\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"90c94f9\",\n \"headCommitOid\": \"90c94f91120c026f5f8bcc586426e8590b7b4048\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 15,\n \"lastCommitDate\": \"2020-04-15T15:53:29.000Z\",\n \"lastCommentDate\": \"2020-04-30T23:07:44.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": true,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-04-30T23:07:49.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": true\n}\n```\n\n
" + "status": "@alexandercerutti Thank you for submitting this PR! \n\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n- [accedo__accedo-one on npm](https://www.npmjs.com/package/accedo__accedo-one)\n - [accedo__accedo-one on unpkg](https://unpkg.com/browse/accedo__accedo-one@latest//)\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can merge changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n
Diagnostic Information: What the bot saw about this PR\n\n```json\n{\n \"type\": \"info\",\n \"now\": \"-\",\n \"pr_number\": 43695,\n \"author\": \"alexandercerutti\",\n \"owners\": [],\n \"dangerLevel\": \"ScopedAndConfiguration\",\n \"headCommitAbbrOid\": \"90c94f9\",\n \"headCommitOid\": \"90c94f91120c026f5f8bcc586426e8590b7b4048\",\n \"mergeIsRequested\": false,\n \"stalenessInDays\": 15,\n \"lastCommitDate\": \"2020-04-15T15:53:29.000Z\",\n \"lastCommentDate\": \"2020-04-30T23:07:44.000Z\",\n \"reviewLink\": \"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43695/files\",\n \"hasMergeConflict\": false,\n \"authorIsOwner\": false,\n \"isFirstContribution\": false,\n \"popularityLevel\": \"Well-liked by everyone\",\n \"anyPackageIsNew\": true,\n \"packages\": [\n \"accedo__accedo-one\"\n ],\n \"files\": [\n {\n \"filePath\": \"types/accedo__accedo-one/accedo__accedo-one-tests.ts\",\n \"kind\": \"test\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/index.d.ts\",\n \"kind\": \"definition\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tsconfig.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n },\n {\n \"filePath\": \"types/accedo__accedo-one/tslint.json\",\n \"kind\": \"package-meta\",\n \"package\": \"accedo__accedo-one\"\n }\n ],\n \"hasDismissedReview\": false,\n \"travisResult\": \"pass\",\n \"lastReviewDate\": \"2020-04-30T23:07:49.000Z\",\n \"reviewersWithStaleReviews\": [\n {\n \"reviewedAbbrOid\": \"a5285cd\",\n \"reviewer\": \"RyanCavanaugh\",\n \"date\": \"2020-04-08T16:23:52Z\"\n }\n ],\n \"approvalFlags\": 0,\n \"isChangesRequested\": true\n}\n```\n\n
" }, { "tag": "reviewer-complaint-90c94f9", diff --git a/src/_tests/labels.test.ts b/src/_tests/labels.test.ts deleted file mode 100644 index 7b137ad27..000000000 --- a/src/_tests/labels.test.ts +++ /dev/null @@ -1,3 +0,0 @@ -test("checks labels", () => { - -}) diff --git a/src/comments.ts b/src/comments.ts index c254b2d7f..185942d94 100644 --- a/src/comments.ts +++ b/src/comments.ts @@ -69,9 +69,9 @@ export const Welcome = (login: string, isFirstPR: boolean) => `@${login} Thank y export const NewDefinition = `Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.`; export const NoOtherReviewers = `Because this PR doesn't have any code reviewers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes.`; -export const PingStaleReviewer = (reviewedAbbrOid: string, reviewer: string) => ({ - tag: `stale-ping-${tinyHash(reviewer)}-${reviewedAbbrOid}`, - status: `@${reviewer} Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?` +export const PingStaleReviewer = (reviewedAbbrOid: string, reviewers: string[]) => ({ + tag: `stale-ping-${tinyHash(reviewers.join("-"))}-${reviewedAbbrOid}`, + status: `@${reviewers.join(", @")} Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?` }); export const AskForAutoMergePermission = (author: string) => ({ diff --git a/src/compute-pr-actions.ts b/src/compute-pr-actions.ts index 12181b6d3..68040b5bb 100644 --- a/src/compute-pr-actions.ts +++ b/src/compute-pr-actions.ts @@ -200,8 +200,10 @@ export function process(info: PrInfo | BotEnsureRemovedFromProject | BotNoPackag } // Ping stale reviewers if any - for (const staleReviewer of info.reviewersWithStaleReviews) { - context.responseComments.push(Comments.PingStaleReviewer(staleReviewer.reviewedAbbrOid, staleReviewer.reviewer)) + if (info.reviewersWithStaleReviews.length) { + const mostRecentReview = [...info.reviewersWithStaleReviews].sort((l, r) => l.date.localeCompare(r.date))[0] + const reviewersDeDuped = [...new Set(info.reviewersWithStaleReviews.map(r => r.reviewer))] + context.responseComments.push(Comments.PingStaleReviewer(mostRecentReview.reviewedAbbrOid, reviewersDeDuped)) } } diff --git a/src/pr-info.ts b/src/pr-info.ts index 73c34703d..927237249 100644 --- a/src/pr-info.ts +++ b/src/pr-info.ts @@ -127,7 +127,7 @@ export interface PrInfo { * A list of people who have reviewed this PR in the past, but for * a prior commit. */ - readonly reviewersWithStaleReviews: ReadonlyArray<{ reviewer: string, reviewedAbbrOid: string }>; + readonly reviewersWithStaleReviews: ReadonlyArray<{ reviewer: string, reviewedAbbrOid: string, date: string }>; /** * A link to the Review tab to provide reviewers with @@ -374,8 +374,8 @@ function authorSaysReadyToMerge(info: PR_repository_pullRequest) { function analyzeReviews(prInfo: PR_repository_pullRequest, isOwner: (name: string) => boolean) { const hasUpToDateReview: Set = new Set(); const headCommitOid: string = prInfo.headRefOid; - /** Key: commit id. Value: reviewer. */ - const staleReviewAuthorsByCommit = new Map(); + /** Key: commit id. Value: review info. */ + const staleReviewAuthorsByCommit = new Map(); let lastReviewDate; let isChangesRequested = false; let approvalFlags = ApprovalFlags.None; @@ -409,16 +409,17 @@ function analyzeReviews(prInfo: PR_repository_pullRequest, isOwner: (name: strin // Stale review // Reviewers with reviews of the current commit are not stale if (!hasUpToDateReview.has(r.author.login)) { - staleReviewAuthorsByCommit.set(r.commit.abbreviatedOid, r.author.login); + staleReviewAuthorsByCommit.set(r.commit.abbreviatedOid, { reviewer: r.author.login, date: r.submittedAt }); } } } return ({ lastReviewDate, - reviewersWithStaleReviews: Array.from(staleReviewAuthorsByCommit.entries()).map(([commit, author]) => ({ + reviewersWithStaleReviews: Array.from(staleReviewAuthorsByCommit.entries()).map(([commit, info]) => ({ reviewedAbbrOid: commit, - reviewer: author + reviewer: info.reviewer, + date: info.date })), approvalFlags, isChangesRequested