Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Panic Handling from Handlers #7

Closed
DeedleFake opened this issue May 4, 2018 · 1 comment
Closed

Remove Panic Handling from Handlers #7

DeedleFake opened this issue May 4, 2018 · 1 comment
Assignees
@DeedleFake
Labels
enhancement New feature or request

Comments

@DeedleFake
Copy link
Owner

golang/go#25245 makes the very good case that handlers shouldn't log panics in the net/http package. I had added panics to the handlers in this package because I was copying net/http's API and behavior for consistency, but they are correct, that makes no sense. So remove it.
@DeedleFake DeedleFake added the enhancement New feature or request label May 4, 2018
@DeedleFake DeedleFake self-assigned this May 4, 2018
@DeedleFake
Copy link
Owner Author

Closed by #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeedleFake DeedleFake

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DeedleFake