From a7e07a79248f31037ae67e5bd044f2ed686cbf09 Mon Sep 17 00:00:00 2001 From: Marine Dunstetter Date: Fri, 24 Feb 2023 14:57:02 +0100 Subject: [PATCH 1/2] BREAKING tests(CI): drop support for ember < 3.28, not compatible with latest ember-qunit --- .github/workflows/ci.yml | 2 -- config/ember-try.js | 16 ---------------- 2 files changed, 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5613e8d..0d4e995 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,8 +20,6 @@ jobs: node-version: 16 package-manager: yarn ember-try-scenarios: "[ - 'ember-lts-3.20', - 'ember-lts-3.24', 'ember-lts-3.28', 'ember-release', 'ember-beta', diff --git a/config/ember-try.js b/config/ember-try.js index c04c127..bbea986 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -7,22 +7,6 @@ module.exports = async function () { return { useYarn: true, scenarios: [ - { - name: 'ember-lts-3.20', - npm: { - devDependencies: { - 'ember-source': '~3.20.5', - }, - }, - }, - { - name: 'ember-lts-3.24', - npm: { - devDependencies: { - 'ember-source': '~3.24.3', - }, - }, - }, { name: 'ember-lts-3.28', npm: { From 19ff80e845669ccf6fa65f26028bc5bbcd80eb56 Mon Sep 17 00:00:00 2001 From: Marine Dunstetter Date: Fri, 24 Feb 2023 15:13:14 +0100 Subject: [PATCH 2/2] tests(CI): allow Canary to fail as ember-qunit is not compatible Ember 5 --- config/ember-try.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/ember-try.js b/config/ember-try.js index bbea986..f2a39e2 100644 --- a/config/ember-try.js +++ b/config/ember-try.js @@ -33,6 +33,9 @@ module.exports = async function () { }, { name: 'ember-canary', + // Can be mandatory again when ember-qunit will be compatible Ember 5 + // https://github.com/emberjs/ember-qunit/issues/1026 + allowedToFail: true, npm: { devDependencies: { 'ember-source': await getChannelURL('canary'),