Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate /tutorial/part-1/interactive-components.md, Ember 5.11 #272

Open
BlueCutOfficial opened this issue Oct 4, 2024 · 0 comments
Open
Labels
Guides FR trad File from the Ember Guides to translate in French

Comments

@BlueCutOfficial
Copy link
Member

Please assign yourself to the issue or let a comment at the very moment you start the translation.

File: guides/tutorial/part-1/interactive-components.md
From Ember: 5.4
To Ember: 5.11

In the snippet below, you can see what changes were done in the latest English documentation. The purpose of this issue is to adjust the French translation to match the new version:

diff --git a/guides/tutorial/part-1/interactive-components.md b/guides/tutorial/part-1/interactive-components.md
index 0757fbc2f..90c563707 100644
--- a/guides/tutorial/part-1/interactive-components.md
+++ b/guides/tutorial/part-1/interactive-components.md
@@ -4,7 +4,7 @@ In this chapter, you will add interactivity to the page, allowing the user to cl
 
 <!-- TODO: make this a gif instead -->
 
-<img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="The Super Rentals app by the end of the chapter (default image size)" width="1024" height="1129">
+<img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="The Super Rentals app by the end of the chapter (default image size)" width="1024" height="1130">
 
 <img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="The Super Rentals app by the end of the chapter (large image size)" width="1024" height="1500">
 
@@ -34,6 +34,8 @@ Ember optionally allows us to associate JavaScript code with a component for exa
 $ ember generate component-class rental/image
 installing component-class
   create app/components/rental/image.js
+
+Running "lint:fix" script...
 
 
 This generated a JavaScript file with the same name as our component's template at `app/components/rental/image.js`. It contains a _[JavaScript class](https://javascript.info/class)_, _[inheriting](https://javascript.info/class-inheritance)_ from `@glimmer/component`.
@@ -56,8 +58,8 @@ Ember will create an _instance_ of the class whenever our component is invoked.
 js { data-filename="app/components/rental/image.js" data-diff="-3,+4,+5,+6,+7,+8,+9" }
 import Component from '@glimmer/component';
 
-export default class RentalImageComponent extends Component {}
-export default class RentalImageComponent extends Component {
+export default class RentalImage extends Component {}
+export default class RentalImage extends Component {
   constructor(...args) {
     super(...args);
     this.isLarge = false;
@@ -101,7 +103,7 @@ Since this pattern of initializing instance variables in the constructor is pret
 js { data-filename="app/components/rental/image.js" data-diff="-4,-5,-6,-7,+8" }
 import Component from '@glimmer/component';
 
-export default class RentalImageComponent extends Component {
+export default class RentalImage extends Component {
   constructor(...args) {
     super(...args);
     this.isLarge = false;
@@ -123,7 +125,7 @@ import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 
-export default class RentalImageComponent extends Component {
+export default class RentalImage extends Component {
   isLarge = false;
   @tracked isLarge = false;
 
@@ -199,7 +201,7 @@ With that, we have created our first _interactive_ component. Go ahead and try i
 
 <!-- TODO: make this a gif instead -->
 
-<img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="&lt;Rental::Image&gt; (default size)" width="1024" height="1129">
+<img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="&lt;Rental::Image&gt; (default size)" width="1024" height="1130">
 
 <img src="/images/tutorial/part-1/interactive-components/[email protected]" alt="&lt;Rental::Image&gt; (large size)" width="1024" height="1500">
 
@BlueCutOfficial BlueCutOfficial added the Guides FR trad File from the Ember Guides to translate in French label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guides FR trad File from the Ember Guides to translate in French
Projects
None yet
Development

No branches or pull requests

1 participant