Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ember-export-application-global removed in Ember.js v4.5.0 #199

Closed
MrChocolatine opened this issue Jul 11, 2022 · 2 comments · Fixed by #246 or #261
Closed

Package ember-export-application-global removed in Ember.js v4.5.0 #199

MrChocolatine opened this issue Jul 11, 2022 · 2 comments · Fixed by #246 or #261

Comments

@MrChocolatine
Copy link
Member

See the release notes:

And the relevant pull request:

Because we rely on this add-on we will need to add a warning.

@BlueCutOfficial
Copy link
Member

What kind of warning do you have in mind? Shouldn't we move this from devDeps to dep or add the install in this addon blueprint when updating to Ember 4.5.0?

@MrChocolatine
Copy link
Member Author

@BlueCutOfficial

What kind of warning do you have in mind? Shouldn't we move this from devDeps to dep or add the install in this addon blueprint when updating to Ember 4.5.0?

I did not have anything specific in mind when writing this, simply "we will need to take care of that".
And yes to what you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants