Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more filed for Master Duel card data #159

Closed
Unknown51335 opened this issue Aug 28, 2024 · 2 comments
Closed

Add more filed for Master Duel card data #159

Unknown51335 opened this issue Aug 28, 2024 · 2 comments

Comments

@Unknown51335
Copy link

Currently, the JSON data returned from this link includes the following fields: ["rarity", "attribute", "types", "atk", "lore", ...]. I understand that this data is retrieved from the API, such as this.

However, the Yugipedia web page offers additional information that is crucial for a comprehensive Master Duel card database. These include fields like:

Craftable: Whether the card can be crafted in the game.
Release Date (specific to Master Duel): When the card was released in the game.
Included Set (specific to Master Duel): Which set the card is part of in the game.
These fields can be extracted from the HTML content returned by a different API endpoint, such as this one. Unfortunately, the API response here is in HTML format, which requires additional parsing to extract the necessary fields.

At this time, I haven't found a more straightforward way to retrieve these specific fields from the API. Including these additional fields would significantly enhance the utility of the Master Duel cards database.

@kevinlul
Copy link
Contributor

Hi, what you're doing is rendering the wikitext templates, which is roughly equivalent to scraping the HTML pages themselves. The release date and set data actually comes from individual set pages like https://yugipedia.com/wiki/Wings_of_the_Guardian. Work on this is currently tracked in DawnbrandBots/yaml-yugipedia#2 and also previously requested in #76.

@Unknown51335
Copy link
Author

Thanks for your reply. I understand now. This is a great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants