Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect embed colour for Normal Monsters without modern prints #174

Closed
kevinlul opened this issue Sep 27, 2022 · 3 comments
Closed

Incorrect embed colour for Normal Monsters without modern prints #174

kevinlul opened this issue Sep 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@kevinlul
Copy link
Contributor

Colour is orange (Main Deck non-Ritual Effect) instead of yellow due to the lack of / Normal in the typeline. Logic in card.ts:createCardEmbed where it calls setColor needs updating, maybe pulling it out of the function to do unit testing.

Examples:

  • Angel Trumpeter
  • Dark Magician, Arcana print

Non-Bastion solution is for yaml-yugi to merge with official card database scrapes for updated type lines even without modern prints.

@kevinlul kevinlul added the bug Something isn't working label Oct 8, 2022
@kevinlul
Copy link
Contributor Author

Any logic update based on purely the type line would be unable to disambiguate for old Tuners, e.g. Ally of Justice Cyclone Creator

@kevinlul
Copy link
Contributor Author

Other examples (possibly only TCG cases):

  • Water Spirit
  • Dragon Core Hexer
  • Angel Trumpeter
  • Tune Warrior

Heuristic: one property in type line implies Normal monster. Still does not cover Tuner cases.

@kevinlul
Copy link
Contributor Author

No longer affected due to https://yugipedia.com/wiki/Template:Unprinted_erratum being applied to affected cards in order to give them / Normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant