Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one-way-select with prompt option auto-selects first element, so you never see the prompt #159

Open
RobIsHere opened this issue May 14, 2017 · 2 comments

Comments

@RobIsHere
Copy link

This example with "prompt=..."
https://github.com/DockYard/ember-one-way-controls/blob/master/docs/one-way-select.md#adding-a-blank-or-prompt-option

auto-selects the first option from start. So the prompt never shows up.

You can use promptIsSelectable=true to work around this issue. But then the user can select the prompt again after he already made a choice. So you also need to validate for presence.

@czosel
Copy link

czosel commented Jun 13, 2017

Hi @RobIsHere, i tried to reproduce your issue but failed - please see this twiddle!

@RobIsHere
Copy link
Author

I have this error again in a new app that's on current release versions all over.

{{one-way-select fileChangeSet.customGalleryPicture options=pictureFiles prompt="Please select one:" optionValuePath="id" optionLabelPath="filename" update=(action (mut fileChangeSet.customGalleryPicture))}}

with fileChangeSet beeing an ember-changeset object based on an ember-data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants