Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay::Role::BusinessRule has some unused attributes #13

Open
byterock opened this issue Apr 28, 2017 · 0 comments
Open

Replay::Role::BusinessRule has some unused attributes #13

byterock opened this issue Apr 28, 2017 · 0 comments

Comments

@byterock
Copy link
Collaborator

package Replay::Role::BusinessRule;

use Moose::Role;
use Moose::Util::TypeConstraints;

our $VERSION = '0.02';

has eventSystem => ( is => 'ro', isa => 'Replay::EventSystem', );
has reportEngine => ( is => 'ro', isa => 'Str', );

When I was diging agout trying to fix something I noticed that Rules that are being used will never have the eventSystem or the reportEngine set at any time

With replayd for example all the rules are 'invoked' loaded into an array then sent to the replay->ruleSource
but at no time is an eventSystem passed to the rules

So as the is a ro var and can only be set at create via a named patam (ie new) they will never be set

is there some reason for each rule has an event system?

Perhaps we can set this to RW then set it when the rules are added if it needs to be there??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant