Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complex-paper-datatable-card.html demo <dom-repeat> filter issues #34

Open
David-Mulder opened this issue Nov 26, 2015 · 3 comments
Open

Comments

@David-Mulder
Copy link
Owner

See Polymer/polymer#3094

Can be temporarily fixed by changing line 4195 in Polymer.html to

keys = keys.filter(function (a, i, keys) {
  return self._filterFn(c.getItem(a), i, keys);
@David-Mulder David-Mulder changed the title Complex paper-datatable-card demo <dom-repeat> filter issues complex-paper-datatable-card.html demo <dom-repeat> filter issues Nov 26, 2015
@moderndeveloperllc
Copy link

So I gather that this needs to be fixed before you implement a filter option in the component?

@David-Mulder
Copy link
Owner Author

@moderndeveloperllc: no, this has nothing to do with a generic filter option. Do feel free to open an issue, but it runs down to this:

  • in the card you can already filter in any way you like (just trigger retrieveVisibleData after changing your filter)
  • in the plain datatable you would need to filter yourself which could maybe be neat to add.

@mercmobily
Copy link

The Polymer developers seem very unwilling to add the array index to the callback for performance reasons. What are the actual consequence to this? I am failing to see the issue! (although it might be completely 100% clear...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants