Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZigZag should not plot line when no thresholds are met #616

Closed
2 tasks done
DaveSkender opened this issue Nov 12, 2021 · 2 comments · Fixed by #618
Closed
2 tasks done

ZigZag should not plot line when no thresholds are met #616

DaveSkender opened this issue Nov 12, 2021 · 2 comments · Fixed by #618
Labels
bug Something isn't working

Comments

@DaveSkender
Copy link
Owner

DaveSkender commented Nov 12, 2021

the [potential] problem

  • Confirm that the last line of ZigZag is not plotting extra interim points before thresholds are met.
  • Add extra unit tests that confirm unusual scenarios - see eval-zigzag branch.

This is a follow-on to #600

to reproduce

See results from the unit test in the above branch. There are some extra zigs at the end, but it could be my unit test is bad or am not interpreting it correctly.

expected behavior

The last line is straight to the last point if it is not long enough to reach a threshold.

@DaveSkender DaveSkender added the question Question and/or answer label Nov 12, 2021
@DaveSkender DaveSkender added bug Something isn't working and removed question Question and/or answer labels Nov 14, 2021
@DaveSkender
Copy link
Owner Author

Lines were plotting when no confirmed extreme points were present in the dataset.

@DaveSkender DaveSkender changed the title Last line of ZigZag should be straight if threshold is not met? ZigZag should not plot line when no thresholds are met Nov 14, 2021
@github-actions
Copy link

This Issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant