Skip to content

Commit 5e999b7

Browse files
committed
NotNull
1 parent b794e3c commit 5e999b7

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

Diff for: driver/src/main/java/com/intellij/CouchbaseMetaData.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.intellij;
22

33
import com.couchbase.client.java.json.JsonObject;
4+
import org.jetbrains.annotations.NotNull;
45

56
import java.sql.Connection;
67
import java.sql.DatabaseMetaData;
@@ -19,7 +20,7 @@ public class CouchbaseMetaData implements DatabaseMetaData {
1920
private final CouchbaseConnection connection;
2021
private final CouchbaseJdbcDriver driver;
2122

22-
CouchbaseMetaData(CouchbaseConnection connection, CouchbaseJdbcDriver driver) {
23+
CouchbaseMetaData(@NotNull CouchbaseConnection connection, @NotNull CouchbaseJdbcDriver driver) {
2324
this.connection = connection;
2425
this.driver = driver;
2526
}

Diff for: driver/src/main/java/com/intellij/CouchbasePreparedStatement.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.couchbase.client.java.Cluster;
44
import com.couchbase.client.java.json.JsonArray;
55
import com.couchbase.client.java.query.QueryOptions;
6+
import org.jetbrains.annotations.NotNull;
67

78
import java.io.InputStream;
89
import java.io.Reader;
@@ -36,7 +37,7 @@ public class CouchbasePreparedStatement extends CouchbaseBaseStatement implement
3637
private final String sql;
3738
private Object[] params;
3839

39-
CouchbasePreparedStatement(Cluster cluster, String sql, boolean returnNullStrings) {
40+
CouchbasePreparedStatement(@NotNull Cluster cluster, @NotNull String sql, boolean returnNullStrings) {
4041
super(cluster);
4142
this.returnNullStrings = returnNullStrings;
4243
this.sql = sql;

Diff for: driver/src/main/java/com/intellij/CouchbaseResultSet.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.couchbase.client.java.json.JsonObject;
44
import com.couchbase.client.java.query.ReactiveQueryResult;
5+
import org.jetbrains.annotations.NotNull;
56
import reactor.core.publisher.Mono;
67

78
import java.io.InputStream;
@@ -45,18 +46,17 @@ public class CouchbaseResultSet implements ResultSet {
4546
private CouchbaseResultSetMetaData meta;
4647
private boolean isClosed = false;
4748

48-
CouchbaseResultSet(Statement statement, Mono<ReactiveQueryResult> queryResult, boolean returnNullStrings) {
49+
CouchbaseResultSet(@NotNull Statement statement, @NotNull Mono<ReactiveQueryResult> queryResult,
50+
boolean returnNullStrings) {
4951
this.statement = statement;
5052
this.stream = queryResult.flux()
5153
.flatMap(ReactiveQueryResult::rowsAsObject)
52-
.doOnRequest(x -> System.err.println("Requested next: " + x))
53-
.doOnCancel(() -> System.err.println("Cancel this flux"))
5454
.toStream();
5555
this.iterator = stream.iterator();
5656
this.returnNullStrings = returnNullStrings;
5757
}
5858

59-
CouchbaseResultSet(Statement statement, Mono<ReactiveQueryResult> queryResult) {
59+
CouchbaseResultSet(@NotNull Statement statement, @NotNull Mono<ReactiveQueryResult> queryResult) {
6060
this(statement, queryResult, true);
6161
}
6262

@@ -85,7 +85,6 @@ public boolean next() throws SQLException {
8585

8686
@Override
8787
public void close() {
88-
System.out.println("Close called");
8988
if (stream != null) {
9089
stream.close();
9190
iterator = Collections.emptyIterator();
@@ -297,7 +296,6 @@ public SQLWarning getWarnings() throws SQLException {
297296

298297
@Override
299298
public void clearWarnings() {
300-
// todo
301299
}
302300

303301
@Override
@@ -425,7 +423,6 @@ public int getFetchDirection() {
425423

426424
@Override
427425
public void setFetchSize(int rows) {
428-
// todo
429426
}
430427

431428
@Override

Diff for: driver/src/main/java/com/intellij/CouchbaseResultSetMetaData.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.intellij;
22

3+
import org.jetbrains.annotations.NotNull;
4+
35
import java.sql.ResultSetMetaData;
46
import java.sql.SQLException;
57
import java.sql.SQLFeatureNotSupportedException;
@@ -18,7 +20,7 @@ public class CouchbaseResultSetMetaData implements ResultSetMetaData {
1820

1921
private final List<ColumnMetaData> columnMetaData;
2022

21-
CouchbaseResultSetMetaData(List<ColumnMetaData> columnMetaData) {
23+
CouchbaseResultSetMetaData(@NotNull List<ColumnMetaData> columnMetaData) {
2224
this.columnMetaData = columnMetaData;
2325
}
2426

Diff for: driver/src/main/java/com/intellij/CouchbaseStatement.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package com.intellij;
22

33
import com.couchbase.client.java.Cluster;
4+
import org.jetbrains.annotations.NotNull;
45

56
import java.sql.ResultSet;
67
import java.sql.SQLException;
78
import java.sql.SQLFeatureNotSupportedException;
89

910
public class CouchbaseStatement extends CouchbaseBaseStatement {
10-
CouchbaseStatement(Cluster cluster) {
11+
CouchbaseStatement(@NotNull Cluster cluster) {
1112
super(cluster);
1213
}
1314

@@ -25,6 +26,7 @@ public ResultSet executeQuery(String sql) throws SQLException {
2526

2627
@Override
2728
public int executeUpdate(String sql) throws SQLException {
29+
//todo: learn to handle update queries
2830
checkClosed();
2931
try {
3032
result = new CouchbaseResultSet(this, cluster.reactive().query(sql));

0 commit comments

Comments
 (0)