Skip to content

Conversation

@IlyasShabi
Copy link
Contributor

Motivation

Separate api sec standalone scenario from asm standalone

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@IlyasShabi IlyasShabi force-pushed the ishabi/api-sec-asm-standalone-scenario branch from 0bb51c0 to fb8954f Compare May 9, 2025 13:43
@IlyasShabi IlyasShabi marked this pull request as ready for review May 9, 2025 14:11
@IlyasShabi IlyasShabi requested review from a team as code owners May 9, 2025 14:11
@IlyasShabi IlyasShabi merged commit 384fa64 into main May 9, 2025
431 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/api-sec-asm-standalone-scenario branch May 9, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants