From 5a820ac20c1616bd96e34cf8c62655c4a13de5f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Vandon?= Date: Wed, 4 Sep 2024 13:47:07 +0200 Subject: [PATCH 1/2] temp disable of test while we change the behavior in dotnet --- tests/integrations/test_dbm.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/integrations/test_dbm.py b/tests/integrations/test_dbm.py index fe70e30aa14..1ff63fcc484 100644 --- a/tests/integrations/test_dbm.py +++ b/tests/integrations/test_dbm.py @@ -113,12 +113,17 @@ def test_trace_payload_service(self): setup_trace_payload_full = weblog_trace_payload @scenarios.integrations + @irrelevant( + context.library == "dotnet", + reason="temporary disable while we add support for DBM full mode for SQL Server in dotnet", + ) def test_trace_payload_full(self): assert self.requests, "No requests to validate" for request in self.requests: span = self._get_db_span(request) - if span.get("meta", {}).get("db.type") == "sql-server": + # full mode for sql server is supported in dotnet (via the context_info) + if self.library_name != "dotnet" and span.get("meta", {}).get("db.type") == "sql-server": self._assert_span_is_untagged(span) else: self._assert_span_is_tagged(span) From 6da2070c66e0142eaef486ead658c587fcc58cfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Vandon?= Date: Wed, 4 Sep 2024 14:12:52 +0200 Subject: [PATCH 2/2] use missing feature instead to have the test run --- tests/integrations/test_dbm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integrations/test_dbm.py b/tests/integrations/test_dbm.py index 1ff63fcc484..f23625feb14 100644 --- a/tests/integrations/test_dbm.py +++ b/tests/integrations/test_dbm.py @@ -6,7 +6,7 @@ import json import re -from utils import weblog, interfaces, context, scenarios, features, irrelevant, flaky +from utils import weblog, interfaces, context, scenarios, features, irrelevant, flaky, missing_feature from utils.tools import logger @@ -113,7 +113,7 @@ def test_trace_payload_service(self): setup_trace_payload_full = weblog_trace_payload @scenarios.integrations - @irrelevant( + @missing_feature( context.library == "dotnet", reason="temporary disable while we add support for DBM full mode for SQL Server in dotnet", )