[service-checks] JMX Serv. checks sent to dd-agent #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elafarge
force-pushed
the
etienne/service-check-count-fix
branch
from
fb57a74 to
d18d888
Compare
|
Thanks for taking care of it @elafarge ! Quite nitpicky: can we count service checks from |
The agents gets, through a jmx_status.yaml file, the service checks sent for each checks. This value is the one displayed when running datadog-agent info. A test has also been added to the counter
elafarge
force-pushed
the
etienne/service-check-count-fix
branch
from
d18d888 to
74d67f9
Compare
Made the code more compliant with DRY good practices. In addition to that it will help to make a cleaner fix for the activemq_58 issue.
|
Should be ready to merge. This being said, this branch is included in #56. Merging the latter would therefore put the two commits from this branch into master without having to merge it :) |
|
Merging 👯 |
yannmh
added a commit
that referenced
this pull request
May 13, 2015
[service-checks] JMX Serv. checks sent to dd-agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agents gets, through a jmx_status.yaml file, the service checks
sent for each checks. This value is the one displayed when running
datadog-agent info.