Skip to content

Fix compatibility with musl libc 1.2.4 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Fix compatibility with musl libc 1.2.4 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ jobs:
config: ${{ fromJson(inputs.configuration) }}
runs-on: ubuntu-latest
container:
image: "alpine:3.14"
image: "alpine:3.21"
options: --cpus 4 --workdir /github/workspace -v /home/runner/work/_temp:/home/runner/work/_temp
timeout-minutes: 180
steps:
Expand Down
5 changes: 4 additions & 1 deletion ddprof-lib/src/main/cpp/symbols_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>

// make sure lseek will use 64 bits offset
#define _FILE_OFFSET_BITS 64
#include <unistd.h>

ElfSection *ElfParser::findSection(uint32_t type, const char *name) {
Expand Down Expand Up @@ -68,7 +71,7 @@ bool ElfParser::parseFile(CodeCache *cc, const char *base,
return false;
}

size_t length = (size_t)lseek64(fd, 0, SEEK_END);
size_t length = (size_t)lseek(fd, 0, SEEK_END);
void *addr = mmap(NULL, length, PROT_READ, MAP_PRIVATE, fd, 0);
close(fd);

Expand Down
Loading