diff --git a/spec/datadog/di/component_spec.rb b/spec/datadog/di/component_spec.rb index 96465563019..d7c75d066a0 100644 --- a/spec/datadog/di/component_spec.rb +++ b/spec/datadog/di/component_spec.rb @@ -23,11 +23,8 @@ context 'when dynamic instrumentation is enabled' do let(:dynamic_instrumentation_enabled) { true } - before do - allow(agent_settings).to receive(:hostname) - allow(agent_settings).to receive(:port) - allow(agent_settings).to receive(:timeout_seconds).and_return(1) - allow(agent_settings).to receive(:ssl) + let(:agent_settings) do + instance_double_agent_settings_with_stubs end context 'when remote config is enabled' do diff --git a/spec/datadog/di/integration/everything_from_remote_config_spec.rb b/spec/datadog/di/integration/everything_from_remote_config_spec.rb index 32d3f1b7300..ac2cb1b986a 100644 --- a/spec/datadog/di/integration/everything_from_remote_config_spec.rb +++ b/spec/datadog/di/integration/everything_from_remote_config_spec.rb @@ -98,12 +98,7 @@ def target_method end let(:agent_settings) do - instance_double_agent_settings.tap do |agent_settings| - allow(agent_settings).to receive(:hostname) - allow(agent_settings).to receive(:port) - allow(agent_settings).to receive(:timeout_seconds).and_return(1) - allow(agent_settings).to receive(:ssl) - end + instance_double_agent_settings_with_stubs end let(:stringified_probe_spec) do diff --git a/spec/datadog/di/integration/instrumentation_spec.rb b/spec/datadog/di/integration/instrumentation_spec.rb index 5dd02583a23..435469a57db 100644 --- a/spec/datadog/di/integration/instrumentation_spec.rb +++ b/spec/datadog/di/integration/instrumentation_spec.rb @@ -140,14 +140,13 @@ def exception_method context 'log probe' do before do - allow(agent_settings).to receive(:hostname) - allow(agent_settings).to receive(:port) - allow(agent_settings).to receive(:timeout_seconds).and_return(1) - allow(agent_settings).to receive(:ssl) - allow(Datadog::DI).to receive(:current_component).and_return(component) end + let(:agent_settings) do + instance_double_agent_settings_with_stubs + end + context 'method probe' do context 'basic probe' do let(:probe) do diff --git a/spec/datadog/di/spec_helper.rb b/spec/datadog/di/spec_helper.rb index 0e460017a16..c14b122daf2 100644 --- a/spec/datadog/di/spec_helper.rb +++ b/spec/datadog/di/spec_helper.rb @@ -100,6 +100,13 @@ def deep_stringify_keys(hash) def instance_double_agent_settings instance_double(Datadog::Core::Configuration::AgentSettings) end + + def instance_double_agent_settings_with_stubs + instance_double( + Datadog::Core::Configuration::AgentSettings, + hostname: "test-host", port: 9000, timeout_seconds: 1, ssl: false + ) + end end end