Skip to content

Commit 41dc832

Browse files
authored
Merge pull request #4257 from DataDog/ivoanjo/add-dependency-on-logger-gem
[NO-TICKET] RFC: Add `logger` gem as dependency to prepare for future Ruby versions
2 parents 7e37aff + 714e329 commit 41dc832

File tree

551 files changed

+1075
-1
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

551 files changed

+1075
-1
lines changed

.gitlab/install_datadog_deps.rb

+2
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,14 @@
7878
'DD_PROFILING_NO_EXTENSION' => 'true',
7979
}
8080

81+
# ADD NEW DEPENDENCIES HERE
8182
[
8283
'datadog-ruby_core_source',
8384
'ffi',
8485
'libddwaf',
8586
'msgpack',
8687
'libdatadog', # libdatadog MUST be installed before datadog to ensure libdatadog native extension is compiled
88+
'logger',
8789
'datadog',
8890
].each do |gem|
8991
version = gem_version_mapping.delete(gem)

datadog.gemspec

+10
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,16 @@ Gem::Specification.new do |spec|
7171
# (and yes we have a test for it)
7272
spec.add_dependency 'libdatadog', '~> 14.3.1.1.0'
7373

74+
# Will no longer be a default gem on Ruby 3.5, see
75+
# https://github.com/ruby/ruby/commit/d7e558e3c48c213d0e8bedca4fb547db55613f7c and
76+
# https://stdgems.org/ .
77+
# We support all versions of this gem and don't particularly require any version restriction.
78+
spec.add_dependency 'logger'
79+
80+
# Tip: When adding or removing dependencies, search the codebase for the string
81+
# ADD NEW DEPENDENCIES HERE
82+
# to find out a few more places that need to be kept in-sync.
83+
7484
spec.extensions = [
7585
'ext/datadog_profiling_native_extension/extconf.rb',
7686
'ext/datadog_profiling_loader/extconf.rb',

gemfiles/jruby_9.2_activesupport.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_aws.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_contrib.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_contrib_old.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_core_old.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_elasticsearch_7.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_elasticsearch_8.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_elasticsearch_latest.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_graphql_2.0.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_http.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_opensearch_2.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_opensearch_3.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_opensearch_latest.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rack_1.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rack_2.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rack_3.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rack_latest.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_mysql2.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_postgres.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_postgres_redis.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_postgres_redis_activesupport.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_postgres_sidekiq.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gemfiles/jruby_9.2_rails5_semantic_logger.gemfile.lock

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)