Skip to content

Conversation

@pabloerhard
Copy link
Contributor

@pabloerhard pabloerhard commented Oct 31, 2025

What does this PR do?

Add ESM test instrumentations that didn't have one.

Motivation

Ensure instrumentations work for ESM and prevent any regression on future ESM work.

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Overall package size

Self size: 13.21 MB
Deduped: 116.15 MB
No deduping: 131.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.82 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.15 | 106.53 kB | 424.55 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.86%. Comparing base (078c9e4) to head (fc5f36f).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6814      +/-   ##
==========================================
+ Coverage   83.73%   83.86%   +0.12%     
==========================================
  Files         501      506       +5     
  Lines       21098    21352     +254     
==========================================
+ Hits        17666    17906     +240     
- Misses       3432     3446      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Oct 31, 2025

Benchmarks

Benchmark execution time: 2025-11-11 17:41:50

Comparing candidate commit fc5f36f in PR branch pabloerhard/new-esm-tests with baseline commit 078c9e4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1605 metrics, 65 unstable metrics.

@pabloerhard pabloerhard force-pushed the pabloerhard/new-esm-tests branch 3 times, most recently from e792781 to c919491 Compare November 6, 2025 20:16
@pabloerhard pabloerhard marked this pull request as ready for review November 6, 2025 20:18
@pabloerhard pabloerhard requested review from a team as code owners November 6, 2025 20:18
@pabloerhard pabloerhard force-pushed the pabloerhard/new-esm-tests branch 2 times, most recently from 70c3ccb to 1ded79e Compare November 6, 2025 20:23
@pabloerhard pabloerhard changed the title Added missing ESM tests (chore): add ESM tests for instrumentations missing them Nov 6, 2025
@pabloerhard pabloerhard marked this pull request as draft November 6, 2025 20:28
@pabloerhard pabloerhard marked this pull request as ready for review November 6, 2025 20:47
@pabloerhard pabloerhard changed the title (chore): add ESM tests for instrumentations missing them chore: add ESM tests for instrumentations missing them Nov 6, 2025
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy to see these tests! They provide a great safety for the future, thank you!

Just two small things, otherwise LGTM

@pabloerhard pabloerhard force-pushed the pabloerhard/new-esm-tests branch from 0fec0c1 to 79844a2 Compare November 7, 2025 15:40
@pabloerhard pabloerhard force-pushed the pabloerhard/new-esm-tests branch 2 times, most recently from 6f109d6 to 9abf677 Compare November 10, 2025 14:47
@pabloerhard pabloerhard force-pushed the pabloerhard/new-esm-tests branch from 9abf677 to 832d63a Compare November 10, 2025 19:39
@pabloerhard pabloerhard requested a review from BridgeAR November 10, 2025 20:31
@pabloerhard pabloerhard requested a review from BridgeAR November 11, 2025 17:56
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@pabloerhard pabloerhard merged commit 5e2ed3d into master Nov 12, 2025
777 of 778 checks passed
@pabloerhard pabloerhard deleted the pabloerhard/new-esm-tests branch November 12, 2025 20:34
@dd-octo-sts dd-octo-sts bot mentioned this pull request Nov 13, 2025
dd-octo-sts bot pushed a commit that referenced this pull request Nov 13, 2025
* Added ESM tests for instrumentations without integration tests

* fix knex ESM and unit tests

* Added todo entry and removed unnecessary require
simon-id pushed a commit that referenced this pull request Nov 13, 2025
* Added ESM tests for instrumentations without integration tests

* fix knex ESM and unit tests

* Added todo entry and removed unnecessary require
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants