Skip to content

Conversation

@tlhunter
Copy link
Member

@tlhunter tlhunter commented Jul 19, 2023

What does this PR do?

  • makes service configuration entirely optional when initializing openai
  • both logger and metrics now have a noop version with method stubs
  • adds a test that loads dd-trace, doesn't inintialize, then loads openai
  • also enables running the tests in CI... whoops...

At a high level an application would require dd-trace but not initialize it, and then would require openai. When this happens all of the tracer configuration is missing and an error would be thrown when accessing a deeply-nested config value. So now there are a few checks to see if things are initialized. If so, continue as usual. If not, load noop classes since tracing won't work right without initialization anyway.

Motivation

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Overall package size

Self size: 4.9 MB
Deduped: 58 MB
No deduping: 58.1 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3420 (2869e5d) into master (87dc2b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3420   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files         214      214           
  Lines        8402     8402           
  Branches       33       33           
=======================================
  Hits         7082     7082           
  Misses       1320     1320           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlhunter tlhunter force-pushed the tlhunter/openai-optional-services branch 4 times, most recently from 8a4a4f1 to ab0b604 Compare July 19, 2023 22:52
@DataDog DataDog deleted a comment from pr-commenter bot Jul 19, 2023
@tlhunter tlhunter force-pushed the tlhunter/openai-optional-services branch from ab0b604 to 2869e5d Compare July 19, 2023 22:59
@pr-commenter
Copy link

pr-commenter bot commented Jul 19, 2023

Benchmarks

Benchmark execution time: 2023-07-19 23:05:39

Comparing candidate commit 2869e5d in PR branch tlhunter/openai-optional-services with baseline commit 87dc2b7 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 472 metrics, 17 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟥 max_rss_usage [+132.268KB; +161.080KB] or [+16.147%; +19.665%]

scenario:plugin-graphql-with-depth-off-18

  • 🟥 max_rss_usage [+117.948KB; +161.504KB] or [+14.367%; +19.672%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟥 max_rss_usage [+125.524KB; +157.168KB] or [+15.216%; +19.052%]

uses: ./.github/actions/testagent/logs
- uses: codecov/codecov-action@v2

openai:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests weren't running in CI at all! I never noticed since I only pushed code if tests passed locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAI: Cannot read properties of null

3 participants