diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml index 93c8ad824c4..433f870d41f 100644 --- a/.github/workflows/plugins.yml +++ b/.github/workflows/plugins.yml @@ -182,24 +182,25 @@ jobs: uses: ./.github/actions/testagent/logs - uses: codecov/codecov-action@v2 - # couchbase: - # runs-on: ubuntu-latest - # services: - # couchbase: - # image: sabrenner/couchbase-server-sandbox:latest - # ports: - # - 8091-8095:8091-8095 - # - 11210:11210 - # env: - # PLUGINS: couchbase - # SERVICES: couchbase - # steps: - # - uses: actions/checkout@v2 - # - uses: ./.github/actions/node/setup - # - run: yarn install - # - uses: ./.github/actions/node/oldest - # - run: yarn test:plugins:ci - # - uses: codecov/codecov-action@v2 + couchbase: + runs-on: ubuntu-latest + services: + couchbase: + image: ghcr.io/datadog/couchbase-server-sandbox:latest + ports: + - 8091-8095:8091-8095 + - 11210:11210 + env: + PLUGINS: couchbase + SERVICES: couchbase + steps: + - uses: actions/checkout@v2 + - uses: ./.github/actions/testagent/start + - uses: ./.github/actions/node/setup + - run: yarn install + - uses: ./.github/actions/node/oldest + - run: yarn test:plugins:ci + - uses: codecov/codecov-action@v2 connect: runs-on: ubuntu-latest diff --git a/docker-compose.yml b/docker-compose.yml index f06d717ff06..c4ab73e14e9 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,7 +1,7 @@ version: "2" services: couchbase: - image: sabrenner/couchbase-server-sandbox:latest + image: ghcr.io/datadog/couchbase-server-sandbox:latest ports: - "127.0.0.1:8091-8095:8091-8095" - "127.0.0.1:11210:11210" diff --git a/packages/datadog-instrumentations/src/couchbase.js b/packages/datadog-instrumentations/src/couchbase.js index a4a0ddd9e77..cd139f42db8 100644 --- a/packages/datadog-instrumentations/src/couchbase.js +++ b/packages/datadog-instrumentations/src/couchbase.js @@ -160,7 +160,7 @@ function wrapV3Query (query) { } // semver >=2 <3 -addHook({ name: 'couchbase', file: 'lib/bucket.js', versions: ['^2.6.5'] }, Bucket => { +addHook({ name: 'couchbase', file: 'lib/bucket.js', versions: ['^2.6.12'] }, Bucket => { const startCh = channel('apm:couchbase:query:start') const finishCh = channel('apm:couchbase:query:finish') const errorCh = channel('apm:couchbase:query:error') @@ -208,7 +208,7 @@ addHook({ name: 'couchbase', file: 'lib/bucket.js', versions: ['^2.6.5'] }, Buck return Bucket }) -addHook({ name: 'couchbase', file: 'lib/cluster.js', versions: ['^2.6.5'] }, Cluster => { +addHook({ name: 'couchbase', file: 'lib/cluster.js', versions: ['^2.6.12'] }, Cluster => { Cluster.prototype._maybeInvoke = wrapMaybeInvoke(Cluster.prototype._maybeInvoke) Cluster.prototype.query = wrapQuery(Cluster.prototype.query) @@ -217,7 +217,7 @@ addHook({ name: 'couchbase', file: 'lib/cluster.js', versions: ['^2.6.5'] }, Clu // semver >=3 <3.2.0 -addHook({ name: 'couchbase', file: 'lib/collection.js', versions: ['>=3.0.0 <3.2.0'] }, Collection => { +addHook({ name: 'couchbase', file: 'lib/collection.js', versions: ['^3.0.7', '^3.1.3'] }, Collection => { wrapAllNames(['upsert', 'insert', 'replace'], name => { shimmer.wrap(Collection.prototype, name, wrapWithName(name)) }) @@ -225,7 +225,7 @@ addHook({ name: 'couchbase', file: 'lib/collection.js', versions: ['>=3.0.0 <3.2 return Collection }) -addHook({ name: 'couchbase', file: 'lib/cluster.js', versions: ['>=3.0.0 <3.2.0'] }, Cluster => { +addHook({ name: 'couchbase', file: 'lib/cluster.js', versions: ['^3.0.7', '^3.1.3'] }, Cluster => { shimmer.wrap(Cluster.prototype, 'query', wrapV3Query) return Cluster }) diff --git a/scripts/install_plugin_modules.js b/scripts/install_plugin_modules.js index 193e0aa8ea3..5e912cfb419 100644 --- a/scripts/install_plugin_modules.js +++ b/scripts/install_plugin_modules.js @@ -12,6 +12,7 @@ const externals = require('../packages/dd-trace/test/plugins/externals') const requirePackageJsonPath = require.resolve('../packages/dd-trace/src/require-package-json') +// Can remove couchbase after removing support for couchbase <= 3.2.0 const excludeList = os.arch() === 'arm64' ? ['couchbase', 'grpc', 'oracledb'] : [] const workspaces = new Set() const versionLists = {}