You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In version 3.11.5 of the mysql2 library (refer to the PR below), some dependencies have been reorganized, and the query, execute, and addCommand methods have been consolidated into the Connection class under the base directory.
Therefore, when creating hooks for the mysql2 library in datadog-instrumentations, it seems necessary to add hooks based on lib/base/connection.js for version 3.11.5.
Additionally, since the query and execute methods in lib/connection.js, lib/pool.js, and lib/pool_cluster.js also reference the query and execute methods in lib/base/connection.js, it is necessary to ensure that they are not hooked redundantly.
In version 3.11.5 of the
mysql2
library (refer to the PR below), some dependencies have been reorganized, and thequery
,execute
, andaddCommand
methods have been consolidated into theConnection
class under thebase
directory.Therefore, when creating hooks for the
mysql2
library indatadog-instrumentations
, it seems necessary to add hooks based onlib/base/connection.js
for version 3.11.5.Additionally, since the
query
andexecute
methods inlib/connection.js
,lib/pool.js
, andlib/pool_cluster.js
also reference thequery
andexecute
methods inlib/base/connection.js
, it is necessary to ensure that they are not hooked redundantly.sidorares/node-mysql2#3081
The text was updated successfully, but these errors were encountered: