Open Telemetry Integration Does not Adhere to Specification

[chrisguitarguy]

Specifically this bit

dd-trace-js/packages/dd-trace/src/opentelemetry/context_manager.js

Lines 25 to 33 in c831ffa

	if (key === SPAN_KEY) {
	return {
	spanContext () {
	const activeSpan = tracer.scope().active()
	const context = activeSpan && activeSpan.context()
	return new SpanContext(context)
	}
	}
	}

Which causes something like this:

import { trace } from '@opentelemetry/api';

const span = trace.getActiveSpan();

To return a span that doesn't actually implement Span (see https://github.com/open-telemetry/opentelemetry-js/blob/957fa3b5e44e43f0cf07adeca8e118f27334dfc3/api/src/trace/span.ts#L33)

Instead it's just a plain object with spanContext and one cannot do something like span.setAttributes(...) that works just fine without datadog's tracer provider.

Would the DD Span implementation alredy take care of this?

dd-trace-js/packages/dd-trace/src/opentelemetry/span.js

Lines 177 to 179 in c831ffa

	spanContext () {
	return new SpanContext(this._ddSpan.context())
	}

[dpnova]

Agreed, there's places where the otel tracer assumes a parent trace is a DD trace too: https://github.com/DataDog/dd-trace-js/blob/master/packages/dd-trace/src/opentelemetry/tracer.js#L36

With DD_TRACE_OTEL_ENABLED this completely breaks

[andrewpuch]

I'm running into a similar issue as @dpnova where parent is null and parent._traceId throws an error.

[dpnova]

I'm running into a similar issue as @dpnova where parent is null and parent._traceId throws an error.

FWIW I left DD_TRACE_OTEL_ENABLED off and manually created the connection between the parent and child span on the boundary of my DD/OTEL traced code. Hope you get it sorted @andrewpuch