Skip to content

Commit e372d88

Browse files
juan-fernandezuurien
authored andcommitted
More beautiful debug logs (#3171)
1 parent 7420171 commit e372d88

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

packages/dd-trace/src/ci-visibility/exporters/agentless/coverage-writer.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
'use strict'
22
const request = require('../../../exporters/common/request')
33
const log = require('../../../log')
4+
const { safeJSONStringify } = require('../../../exporters/common/util')
45

56
const { CoverageCIVisibilityEncoder } = require('../../../encode/coverage-ci-visibility')
67
const BaseWriter = require('../../../exporters/common/writer')
78

8-
function safeJSONStringify (value) {
9-
return JSON.stringify(value, (key, value) =>
10-
key !== 'dd-api-key' ? value : undefined
11-
)
12-
}
13-
149
class Writer extends BaseWriter {
1510
constructor ({ url, evpProxyPrefix = '' }) {
1611
super(...arguments)

packages/dd-trace/src/ci-visibility/exporters/agentless/writer.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
'use strict'
22
const request = require('../../../exporters/common/request')
3+
const { safeJSONStringify } = require('../../../exporters/common/util')
34
const log = require('../../../log')
45

56
const { AgentlessCiVisibilityEncoder } = require('../../../encode/agentless-ci-visibility')
67
const BaseWriter = require('../../../exporters/common/writer')
78

8-
function safeJSONStringify (value) {
9-
return JSON.stringify(value, (key, value) =>
10-
key !== 'dd-api-key' ? value : undefined
11-
)
12-
}
13-
149
class Writer extends BaseWriter {
1510
constructor ({ url, tags, evpProxyPrefix = '' }) {
1611
super(...arguments)
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
function safeJSONStringify (value) {
2+
return JSON.stringify(
3+
value,
4+
(key, value) => key !== 'dd-api-key' ? value : undefined,
5+
process.env.DD_TRACE_BEAUTIFUL_LOGS ? 2 : undefined
6+
)
7+
}
8+
9+
module.exports = { safeJSONStringify }

packages/dd-trace/src/exporters/common/writer.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
const request = require('./request')
44
const log = require('../../log')
5+
const { safeJSONStringify } = require('./util')
56

67
class Writer {
78
constructor ({ url }) {
@@ -25,11 +26,11 @@ class Writer {
2526

2627
append (payload) {
2728
if (!request.writable) {
28-
log.debug(() => `Maximum number of active requests reached. Payload discarded: ${JSON.stringify(payload)}`)
29+
log.debug(() => `Maximum number of active requests reached. Payload discarded: ${safeJSONStringify(payload)}`)
2930
return
3031
}
3132

32-
log.debug(() => `Encoding payload: ${JSON.stringify(payload)}`)
33+
log.debug(() => `Encoding payload: ${safeJSONStringify(payload)}`)
3334

3435
this._encode(payload)
3536
}

0 commit comments

Comments
 (0)