Commit c020225
Ensure net.bytebuddy.raw is set to true when ConfigTransformSpockExtension is installed (#8728)
This matches the same setting used by AgentInstaller which avoids spurious test failures
in agent-tooling, specifically TypeFactoryForkedTest. This requires raw-types enabled to
match the behaviour when installing the tracer with -javaagent. Without this byte-buddy
will use dufferent code paths involving generic checks, which can lead to test failures
using recent versions of byte-buddy (specifically going between full and outline types,
where outlines are always raw-types by their nature.)
These failures would not happen when using -javaagent because AgentInstaller forces the
use of the raw-types setting. ConfigTransformSpockExtension should therefore do the same.
Note we can't set this property in TypeFactoryForkedTest because by then it is too late,
byte-buddy is already confgured by ConfigTransformSpockExtension and the raw-types value
cannot be changed.1 parent 767540d commit c020225
File tree
2 files changed
+9
-0
lines changed- dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/tooling/bytebuddy/outline
- utils/test-utils/src/main/groovy/datadog/trace/test/util
2 files changed
+9
-0
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
21 | 26 | | |
22 | 27 | | |
23 | 28 | | |
| |||
0 commit comments