Skip to content

Commit 92e8ad6

Browse files
committed
exclude some parallel
1 parent ac67ac1 commit 92e8ad6

File tree

2 files changed

+25
-6
lines changed

2 files changed

+25
-6
lines changed

dd-java-agent/instrumentation/servlet/request-3/src/test/groovy/JettyServlet3Test.groovy

+10
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,11 @@ class JettyServlet3TestAsyncDispatchOnAsyncTimeout extends JettyServlet3Test {
474474
true
475475
}
476476

477+
@Override
478+
boolean testParallelRequest() {
479+
false
480+
}
481+
477482
@Override
478483
void handlerSpan(TraceAssert trace, ServerEndpoint endpoint = SUCCESS) {
479484
dispatchSpan(trace, endpoint)
@@ -532,6 +537,11 @@ class JettyServlet3ServeFromAsyncTimeout extends JettyServlet3Test {
532537
boolean testException() {
533538
false
534539
}
540+
541+
@Override
542+
boolean testParallelRequest() {
543+
false
544+
}
535545
}
536546

537547
class IastJettyServlet3ForkedTest extends JettyServlet3TestSync {

dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy

+15-6
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,10 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
384384
false // not all servers support session ids
385385
}
386386

387+
boolean testParallelRequest() {
388+
true
389+
}
390+
387391
@Override
388392
int version() {
389393
return 0
@@ -530,15 +534,20 @@ abstract class HttpServerTest<SERVER> extends WithHttpServer<SERVER> {
530534
@Flaky(value = "https://github.com/DataDog/dd-trace-java/issues/4690", suites = ["MuleHttpServerForkedTest"])
531535
def "test success with #count requests"() {
532536
setup:
537+
def responses
533538
def request = request(SUCCESS, method, body).build()
534-
def executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors())
535-
def completionService = new ExecutorCompletionService(executor)
536-
(1..count).each {
537-
completionService.submit {
538-
client.newCall(request).execute()
539+
if (testParallelRequest()) {
540+
def executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors())
541+
def completionService = new ExecutorCompletionService(executor)
542+
(1..count).each {
543+
completionService.submit {
544+
client.newCall(request).execute()
545+
}
539546
}
547+
responses = (1..count).collect { completionService.take().get() }
548+
} else {
549+
responses = (1..count).collect {client.newCall(request).execute()}
540550
}
541-
def responses = (1..count).collect {completionService.take().get()}
542551

543552
if (isDataStreamsEnabled()) {
544553
TEST_DATA_STREAMS_WRITER.waitForGroups(1)

0 commit comments

Comments
 (0)