diff --git a/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java b/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java index b56d4f50424..730564445d2 100644 --- a/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java +++ b/dd-java-agent/instrumentation/java-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java @@ -41,6 +41,7 @@ public static CharSequence afterInit( @CallSite.After("java.lang.StringBuilder java.lang.StringBuilder.append(java.lang.StringBuffer)") @CallSite.After("java.lang.StringBuffer java.lang.StringBuffer.append(java.lang.String)") @CallSite.After("java.lang.StringBuffer java.lang.StringBuffer.append(java.lang.CharSequence)") + @CallSite.After("java.lang.StringBuffer java.lang.StringBuffer.append(java.lang.StringBuffer)") @Nonnull public static CharSequence afterAppend( @CallSite.This @Nonnull final CharSequence self, @@ -59,6 +60,8 @@ public static CharSequence afterAppend( @CallSite.After( "java.lang.StringBuilder java.lang.StringBuilder.append(java.lang.CharSequence, int, int)") + @CallSite.After( + "java.lang.StringBuffer java.lang.StringBuffer.append(java.lang.CharSequence, int, int)") @Nonnull public static CharSequence afterAppendWithSubstring( @CallSite.This @Nonnull final CharSequence self, diff --git a/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy b/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy index c989aa9f77d..da45bf012e2 100644 --- a/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy +++ b/dd-java-agent/instrumentation/java-lang/src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy @@ -63,13 +63,13 @@ class StringBuilderCallSiteTest extends AgentTestRunner { 0 * _ where: - suite | target | param | expected - new TestStringBuilderSuite() | new StringBuilder('Hello ') | 23.5F | 'Hello 23.5' - new TestStringBuilderSuite() | new StringBuilder('Hello ') | new StringBuffer('World!') | 'Hello World!' - new TestStringBuilderSuite() | new StringBuilder('Hello ') | 'World!' | 'Hello World!' - new TestStringBufferSuite() | new StringBuffer('Hello ') | 23.5F | 'Hello 23.5' - new TestStringBufferSuite() | new StringBuffer('Hello ') | new StringBuilder('World!') | 'Hello World!' - new TestStringBufferSuite() | new StringBuffer('Hello ') | 'World!' | 'Hello World!' + suite | target | param | expected + new TestStringBuilderSuite() | sb('Hello ') | 23.5F | 'Hello 23.5' + new TestStringBuilderSuite() | sb('Hello ') | sbf('World!') | 'Hello World!' + new TestStringBuilderSuite() | sb('Hello ') | 'World!' | 'Hello World!' + new TestStringBufferSuite() | sbf('Hello ') | 23.5F | 'Hello 23.5' + new TestStringBufferSuite() | sbf('Hello ') | sbf('World!') | 'Hello World!' + new TestStringBufferSuite() | sbf('Hello ') | 'World!' | 'Hello World!' } void 'test string builder append object throwing exceptions'() { @@ -104,8 +104,9 @@ class StringBuilderCallSiteTest extends AgentTestRunner { 0 * _ where: - suite | target | param | start | end | expected - new TestStringBuilderSuite() | new StringBuilder('Hello ') | 'World!' | 0 | 5 | 'Hello World' + suite | target | param | start | end | expected + new TestStringBuilderSuite() | sb('Hello ') | 'World!' | 0 | 5 | 'Hello World' + new TestStringBufferSuite() | sbf('Hello ') | 'World!' | 0 | 5 | 'Hello World' } void 'test string builder toString call site'() {