Skip to content

Commit 630faf3

Browse files
Address review comments
1 parent 65f3139 commit 630faf3

File tree

1 file changed

+13
-19
lines changed

1 file changed

+13
-19
lines changed

dd-trace-core/src/main/java/datadog/trace/core/util/StackTraces.java

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package datadog.trace.core.util;
22

33
import java.io.BufferedReader;
4-
import java.io.IOException;
54
import java.io.PrintWriter;
65
import java.io.StringReader;
76
import java.io.StringWriter;
@@ -56,24 +55,19 @@ static String truncate(String trace, int maxChars) {
5655

5756
private static String abbreviatePackageNames(String trace) {
5857
StringBuilder sb = new StringBuilder(trace.length());
59-
try (BufferedReader reader = new BufferedReader(new StringReader(trace))) {
60-
String line;
61-
while ((line = reader.readLine()) != null) {
62-
Matcher m = FRAME.matcher(line);
63-
if (m.matches()) {
64-
sb.append("\tat ").append(abbreviatePackageName(m.group(1))).append(m.group(2));
65-
} else {
66-
sb.append(line);
67-
}
68-
sb.append(System.lineSeparator());
69-
}
70-
trace = sb.toString();
71-
return trace;
72-
73-
} catch (IOException ignored) {
74-
// This should never happen since we are reading from a StringReader
75-
return trace;
76-
}
58+
new BufferedReader(new StringReader(trace))
59+
.lines()
60+
.forEach(
61+
line -> {
62+
Matcher m = FRAME.matcher(line);
63+
if (m.matches()) {
64+
sb.append("\tat ").append(abbreviatePackageName(m.group(1))).append(m.group(2));
65+
} else {
66+
sb.append(line);
67+
}
68+
sb.append(System.lineSeparator());
69+
});
70+
return sb.toString();
7771
}
7872

7973
/**

0 commit comments

Comments
 (0)