Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Panic from v1.66 on startup #2923

Open
picollomartin opened this issue Oct 10, 2024 · 1 comment
Open

[BUG] Panic from v1.66 on startup #2923

picollomartin opened this issue Oct 10, 2024 · 1 comment
Assignees
Labels
bug unintended behavior that has to be fixed

Comments

@picollomartin
Copy link

Version of dd-trace-go
v.1.68.0

Describe what happened:
With an upgrade from version 1.58 to latest 1.68, tracer start to panic

We trace down the panic to this PR, because occurs here:

PropagationStyleInject: cp.injectorNames,
PropagationStyleExtract: cp.extractorsNames,

Workaround is disable startup log (by env variable or in code)

Describe what you expected:
Not panic, instead if propagator is not the expected one ignore those fields

Steps to reproduce the issue:

  • Override with some custom propagator using tracer.WithPropagator
  • Start tracer with tracer.WithLogStartup(true) (enabled by default, you can skip this)
  • Tracer panics when reach this lines

Additional environment details (Version of Go, Operating System, etc.):
Go 1.22 - linux

@picollomartin picollomartin added the bug unintended behavior that has to be fixed label Oct 10, 2024
@github-actions github-actions bot added the needs-triage New issues that have not yet been triaged label Oct 10, 2024
@mtoffl01 mtoffl01 self-assigned this Oct 11, 2024
@mtoffl01
Copy link
Contributor

Thanks for reporting this! We're working on a fix for it now.

@mtoffl01 mtoffl01 removed the needs-triage New issues that have not yet been triaged label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants