fix: declare @aws-sdk/client-secrets-manager as peer dep #693
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@aws-sdk/client-secrets-manageras an optional peer depMotivation
One of our team ran into:
There's nothing which explicitly tells you to install this so we should probably declare it as an optional peer dependency so consumers who aren't using bundlers can at least know they're missing a dep? Or are we relying on the lambda runtime to bring it in?
Testing Guidelines
N/A
Additional Notes
N/A
Types of Changes
Check all that apply