Only add safe.directory to git global config in CI and Docker contexts#2152
Merged
Conversation
…ntexts Personal laptops were having their global git config modified on every `yarn test` run. The safe.directory workaround is only needed when the repo is checked out by a different user (Docker volume mounts, CI envs). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Drarig29
added
the
datadog-ci
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nikita-tkachenko-datadog
approved these changes
Mar 9, 2026
GabrielAnca
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Personal laptops were having their global git config modified on every
yarn testand normal runs. Thesafe.directoryworkaround is only needed when the repo is checked out by a different user (Docker volume mounts, CI envs).Related:
/was safe in docker image entrypoint #1688How?
Only add cwd to safe directories in Docker and CI contexts.
Review checklist