-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PlayReady PSSH/PRO from Manifest instead of MPD #3423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you see multiple license requests? One with the pssh from the segments and one with the pssh from the manifest? Usually the pssh from the manifest should be preferred by dash.js. However, there is no settings flag to control this. Can you check if it works when you uncomment the encrypted event:
|
@Doolali Any updates on this? |
As far as I remember we were only getting a single license request with the pssh from the segment. @dsilhavy Will have a test this weekend and get back to you! |
@Doolali Is this issue still relevant or can we close it? |
Closing due to inactivity |
I reopen this issue since I have somehow same question: how can we ignore the pssh from init segments (mp4) in case the pssh is provided in the manifest and differs from the one in init segment and while we should rely primarily on the pssh from manifest? Also you can find in section 8 of DASH-IF guidelines regarding content protection: https://dashif-documents.azurewebsites.net/Guidelines-Security/master/Guidelines-Security.html#:~:text=Initialization%20segments%20SHOULD,specific%20ContentProtection%20descriptors.: In dash.js, if we have pssh in manifest, shouldn't we ignore pssh from init segments? |
Easiest workaround would certainly be to add a settings flag like I think ignoring it in general is dangerous. I saw streams that did not update the pssh in the manifest after a key rotation but only the one in the segments. |
Yes, we should keep backward compatibility with those streams. |
@bbert @Doolali As part of #3793 I added a new flag function _onNeedKey(event, retry) {
if (!settings.get().streaming.protection.ignoreEmeEncryptedEvent) {
// Rest of the code
}
} Is this sufficient for your use case? |
Yes fine !! That's the way I tried |
Implemented as part of #3793 . In order to use this feature, adjust the settings as described here: https://github.com/Dash-Industry-Forum/dash.js/wiki/Digital-Rights-Management-(DRM)-and-license-acquisition#ignoring-init-data-from-the-pssh |
Quick question, how do you force dash.js to use the pssh/pro from the manifest instead of the mp4.
I have fixed some data in the manifest but when received the PlayReady license request on the server it's using the old data that's encoded into the mp4.
The text was updated successfully, but these errors were encountered: