Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Content] duration dataType issue in Image AdaptationSet #17

Open
GouravSna opened this issue Feb 8, 2022 · 4 comments
Open

[Test Content] duration dataType issue in Image AdaptationSet #17

GouravSna opened this issue Feb 8, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@GouravSna
Copy link

I am using sample content given here https://reference.dashif.org/dash.js/nightly/samples/dash-if-reference-player/index.html
for DASH thumbnails. https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_4_tiles_thumbnails.mpd

I am using ExoPlayer in Android and after using this content, I am getting a exception on Image thumbnail parsing.
As per the compliance, duration should be in seconds (unsigned Int) but in the above media it is in float.
ExoPlayer question: google/ExoPlayer#9938

Doc says:

@duration expresses the duration of one tile in the media presentation timeline in the
timescale provided by the value of the @timescale attribute, if present, otherwise in
seconds. The value is referred to as tduration in the following.

<AdaptationSet id="3" mimeType="image/jpeg" contentType="image">
            <SegmentTemplate media="$RepresentationID$/tile_$Number$.jpg" duration="634.566" startNumber="1"/>
            <Representation bandwidth="12000" id="thumbnails_102x58" width="1024" height="1152">
                <EssentialProperty schemeIdUri="http://dashif.org/thumbnail_tile" value="10x20"/>
            </Representation>
            <Representation bandwidth="24000" id="thumbnails_256x144" width="2048" height="1152">
                <EssentialProperty schemeIdUri="http://dashif.org/thumbnail_tile" value="8x8"/>
            </Representation>
        </AdaptationSet>

Issue: As per the compliance, duration should be in unsigned int not in float.

@GouravSna GouravSna added the bug Something isn't working label Feb 8, 2022
@rbouqueau
Copy link
Collaborator

This manifest was not created as part of this repository.

@wilaw This is the Akamai folder. Are you able to provide guidance here?

@wilaw
Copy link
Member

wilaw commented Feb 8, 2022

@GouravSna - good catch. @rbouqueau - I will fix this. Can we agree that the change below would be correct?

        <SegmentTemplate media="$RepresentationID$/tile_$Number$.jpg" timescale="1000" duration="634566" startNumber="1"/>
        <Representation bandwidth="12000" id="thumbnails_102x58" width="1024" height="1152">
            <EssentialProperty schemeIdUri="http://dashif.org/thumbnail_tile" value="10x20"/>
        </Representation>
        <Representation bandwidth="24000" id="thumbnails_256x144" width="2048" height="1152">
            <EssentialProperty schemeIdUri="http://dashif.org/thumbnail_tile" value="8x8"/>
        </Representation>
    </AdaptationSet>

@GouravSna
Copy link
Author

GouravSna commented Feb 9, 2022

@wilaw , Do you think that there could be a float value for duration ?

Because in ExoPlayer, it is always being parsed as long value from SegmentTemplate,
https://github.com/google/ExoPlayer/blob/029a2b27cbdc27cf9d51d4a73ebeb503968849f6/[…]android/exoplayer2/source/dash/manifest/DashManifestParser.java

And if timescale and duration is given then duration should be divided by timescale value which comes out to be a fractional value.
@ojw28, Please correct me if my understanding is wrong.

@freeboub
Copy link

freeboub commented Jun 20, 2024

+1
Same issue can be found in following playlist: https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_multiple_tiled_thumbnails.mpd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants