Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: change system calls to fork/exec and CreateProcess #1543

Open
EmosewaMC opened this issue Apr 10, 2024 · 2 comments
Open

ENH: change system calls to fork/exec and CreateProcess #1543

EmosewaMC opened this issue Apr 10, 2024 · 2 comments
Labels
enhancement New feature or request P-Fixer This issue is confirmed, but is not prioritized to be fixed.

Comments

@EmosewaMC
Copy link
Collaborator

Is your feature request related to a problem?

This would allow for more control over security, less work being done by master and better heartbeat controls for detecting if a server is alive or dead.

Describe the solution you'd like

Replace calls to system with fork/exec on *nix and CreateProcess on Windows.

Repository breaking implications

Could prevent servers from starting on platforms without those commands.

Describe alternatives you've considered

continuing to use system and being complacent

Additional context

https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessa
https://man7.org/linux/man-pages/man2/fork.2.html
https://man7.org/linux/man-pages/man3/exec.3.html
https://linux.die.net/man/3/execv

@EmosewaMC EmosewaMC added enhancement New feature or request P-Fixer This issue is confirmed, but is not prioritized to be fixed. labels Apr 10, 2024
@jadebenn
Copy link
Collaborator

Do you have a sample of the code you have in mind to be changed? I'm wondering if there's a C++ or POSIX API that might have more cross-platform compatibility.

@EmosewaMC
Copy link
Collaborator Author

There is no standard way of doing this. It will differ based on platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-Fixer This issue is confirmed, but is not prioritized to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants