Skip to content

fixed toml parser ignoring style #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 10, 2022
Merged

fixed toml parser ignoring style #156

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d083824
fixed toml parser ignoring style
jspaezp Sep 7, 2022
856b248
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 7, 2022
f63dc88
added testing for style in toml
jspaezp Sep 7, 2022
e5ca51e
Merge branch 'bugfix/toml_ignoring_style' of github.com:jspaezp/pydoc…
jspaezp Sep 7, 2022
528f5f2
fixed R1705 from linter and added no cover comment
jspaezp Sep 7, 2022
48a2997
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 7, 2022
d5819fb
Update pydocstringformatter/_configuration/toml_parsing.py
jspaezp Sep 7, 2022
e755c4a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 7, 2022
25ebff3
Style changes
DanielNoord Sep 8, 2022
07ef043
Merge remote-tracking branch 'upstream/main' into bugfix/toml_ignorin…
jspaezp Sep 8, 2022
c16452b
implemented code review changes
jspaezp Sep 9, 2022
974ef0c
added testing for multiple styles in toml
jspaezp Sep 9, 2022
86ef24f
added data for the former test
jspaezp Sep 9, 2022
8896dcc
added correct handling of extend actions in parser
jspaezp Sep 10, 2022
64670a4
Apply suggestions from code review
DanielNoord Sep 10, 2022
f4ee706
Apply suggestions from code review
DanielNoord Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pydocstringformatter/_configuration/toml_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,16 @@ def parse_toml_option(
if value is True:
return [action.option_strings[0]]
return []
if isinstance(action, argparse._StoreAction):
elif isinstance(action, argparse._StoreAction):
if isinstance(value, int):
value = str(value)
return [action.option_strings[0], value]
return [] # pragma: no cover
elif isinstance(action, argparse._ExtendAction):
if isinstance(value, str):
value = str(value)
return [action.option_strings[0], value]
else:
raise NotImplementedError


def parse_toml_file(
Expand Down