Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection drawer render order bug #65

Closed
wants to merge 2 commits into from
Closed

Fix collection drawer render order bug #65

wants to merge 2 commits into from
+153 −26

Commits on Apr 19, 2019

  1. Fixed issue with reorderable list elements 

    * Renamed the existing method DrawPropertyDrawer to DrawPropertyDrawerLayout to indicate it used the native Unity auto-layout controls and created a new method using the older method name that uses the non-layout controls. Added method documentation to both explaining their usage.
* Changed BaseVariableEditor to use the new DrawPropertyDrawerLayout method name.
* Cleaned up CollectionEditor and removed several redundant calls to modify the rect, redundant callbacks, etc..
* Fixed a bug in CollectionEditor where the ReorderableList elements were being drawn by EditorGUILayout methods. These elements act similarly to PropertyDrawers in that they do not respect the auto-layout system methods and need to drawn using the non-layout methods that accept a Rect. I have added usage of callback `elementHeightCallback` so that the height of the element rect can vary depending on the generic T type element's property drawer and changed the element drawing logic to use a non-layout version of the same method from GenericPropertyDrawer. The end result is that these elements are now drawn inline with the reorderable list element instead of below the entire list.
    @jzapdot
    jzapdot committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    9c44097 View commit details
    Browse the repository at this point in the history

  2. PR Test Content 

    * This is a PR content commit that can be discarded after review/approval.
    @jzapdot
    jzapdot committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    98a59b6 View commit details
    Browse the repository at this point in the history