New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Remove 'seal' from XXXVariable to enable inheritance and add expression #161

Open

abcjjy opened this issue Jan 19, 2022 · 1 comment

abcjjy commented Jan 19, 2022

Expression SO can inherit variables and make SOA more powerful and flexiable.

For example

class ComparisonExpression : BoolVariable
{
  public BaseVariable var1;
  public CompareOperator op;
  public BaseVariable var2;

  public override bool Value
  {
    get {
    // compare var1 and var2
    }
  }
}

lgarczyn commented Jan 31, 2023

I agree. This platform is interesting for its hackability, I don't see the point in sealed classes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment