Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the levelFlag in class Destination is never used #122

Closed
cloudwu opened this issue Feb 10, 2020 · 2 comments
Closed

the levelFlag in class Destination is never used #122

cloudwu opened this issue Feb 10, 2020 · 2 comments
Assignees
@DanielChappuis
Labels
bug
Milestone
Version 0.8.0

Comments

@cloudwu
Copy link

cloudwu commented Feb 10, 2020 •
edited
Loading

https://github.com/DanielChappuis/reactphysics3d/blob/develop/src/utils/Logger.h#L328

levelFlag is stored on constructor, but never be used. I guess we should check this flag before Destination::write . So that we can ignore some log levels when we new a Logger object.
@DanielChappuis DanielChappuis self-assigned this Feb 10, 2020
@DanielChappuis
Copy link
Owner

Thanks a lot for reporting this. I will check that.

@DanielChappuis DanielChappuis added this to the Version 0.8.0 milestone Feb 10, 2020
@DanielChappuis
Copy link
Owner

The version v0.8.0 of ReactPhysics3D has been released. In this version, this issue is now fixed.

Thanks a lot for reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielChappuis DanielChappuis

Labels
bug
Projects
None yet
Milestone
Version 0.8.0
Development

No branches or pull requests
2 participants
@cloudwu @DanielChappuis