Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PdoPgsql tests #6

Open
Danack opened this issue May 7, 2023 · 0 comments
Open

PdoPgsql tests #6

Danack opened this issue May 7, 2023 · 0 comments

Comments

@Danack
Copy link
Owner

Danack commented May 7, 2023

Hi @tontonsb,

So, I just added all of the PdoPgsql methods in commit #83bb08c495cee0cc9d234296d70f8c009de6b95b

There are quite a few existing tests for these methods against the PDO class. It doesn't feel right to just copy all of these tests, as that would be a lot of duplication.

Do you want to have a think as see if you can come up with a cunning way to run the existing tests both with the DB connection construction going through PDO::connect, rather than new PDO() as well as with the current new PDO().

Eventually the versions of the methods on the PDO class will be deprecated and removed, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant