Fix #44 (addMatomo being called twice) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwilson
reviewed
Dec 13, 2023
| // Fix #44. This function is being called twice from OutputPage (seems to be an upstream bug). | ||
| static $called = false; | ||
|
|
||
| if($called) { return; } |
There was a problem hiding this comment.
How will $called ever be anything other than false at this point? It looks like this will never return early.
There was a problem hiding this comment.
In PHP a static variable defined in a function only exists within that function (or method in this case) but does not lose its value upon the function returning. See https://www.php.net/manual/en/language.variables.scope.php#language.variables.scope.static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the pull request to fix #44.