Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vocabulary preloadlevel fix #3819

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Vocabulary preloadlevel fix #3819

wants to merge 4 commits into from

Conversation

AAwouters
Copy link
Contributor

@AAwouters AAwouters commented Jan 10, 2025 •
edited
Loading

References

Backports

#3820
#3821

Description

Two changes are made:
Before initializing a treeview, an attempt is made to retrieve the preloadLevel value for the opened vocabulary.
If a value is found the preloadLevel is set to that value, otherwise 1 is used.

Whenever a node is initialized and that node is on a level lower than the preloadLevel, that node is immediately expanded.

Instructions for Reviewers

  • Set config for preLoadLevel, e.g. vocabulary.plugin.srsc.hierarchy.preloadLevel = 3 (values greater than 3 are not recommended for 'srsc')
  • Open Browse 'By Subject Category' page (browse/srsc)
  • The tree is immediately expanded up to 3 levels

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@AAwouters
122839: Load nodes up to defined preloadLevel
cee9d04
@AAwouters
122839: Retrieve preloadLevel from vocabulary before creating tree
9406f7b
@AAwouters
122839: Fix vocabulary-treeview component tests
4ffde92
@AAwouters
Merge branch 'w2p-122839_vocabulary-preloadlevel-fix' into vocabulary…
5df7471 
…-preloadlevel-fix-main

# Conflicts:
#	src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.spec.ts
#	src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.ts
@AAwouters AAwouters changed the title Vocabulary preloadlevel fix main Vocabulary preloadlevel fix Jan 10, 2025
This was referenced Jan 10, 2025
Open
Open
@tdonohue tdonohue added bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns 1 APPROVAL pull request only requires a single approval to merge labels Jan 10, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AAwouters AAwouters

Labels
1 APPROVAL pull request only requires a single approval to merge bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns
Projects
DSpace 9.0 Release
Status: 🙋 Needs Reviewers Assigned
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Vocabulary treeview does not respect preloadLevel configuration
2 participants
@AAwouters @tdonohue