-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
for reserves to ROOT if conc too great (overflow!) #407
Comments
This is in CER_Growth.for, line 737. TVR1 uses values SENLFG and SENLFGRS which are calculated later in the routine. Maybe this TVR1 calculation could be moved later in the routine to use today's senescence values. I don't think it should go to integrate because it is still a rate calculation. |
Linking directly for convenience: dssat-csm-os/Plant/CERES-Wheat_Barley/CER_Growth.for Lines 737 to 745 in 185324f
Just did a quick search and we'd need to be careful about where we move it, because dssat-csm-os/Plant/CERES-Wheat_Barley/CER_Growth.for Lines 748 to 763 in 185324f
and
The dependency graph seems to balloon rather quickly after that. Would it be easier to move senescence calculations earlier? |
@palderman Thanks for looking. Yes, maybe. But it might be circular logic and we just need to live with the fact that this is a daily model. |
I agree move senescence calculations earlier |
IF (((LFWT+GROLF-SENLFG-SENLFGRS) ! Prevent divide by zero
& +(STWT+GROST)+(RSWT+GRORS)) .GT. 0.0)THEN
TVR1 = ! Conc
& (RSWT+GRORS-SENRS)/
& ((LFWT+GROLF-SENLFG-SENLFGRS)
& +(STWT+GROST)+(RSWT+GRORS))
ELSE
TVR1 = 0.0
END IF
SENLFG、SENLFGRS why these variables use yesterday’s variables,maybe can move to integr
The text was updated successfully, but these errors were encountered: