Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bumped the glm version and adjusted the tests #83

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

PeterStaar-IBM
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM commented Sep 17, 2024

Thanks to this update, the column and row headers in tables are correctly propagated in the processing pipeline.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@PeterStaar-IBM PeterStaar-IBM changed the title bumped the glm version and adjusted the tests fix: bumped the glm version and adjusted the tests Sep 17, 2024
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently broken because of wrong merges with main. We must clear those and ensure CI ran successfully or restart from scratch.

Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm force-pushed the fix/propagate-tablecell-types branch from fa1eaf1 to 57a34b6 Compare September 17, 2024 17:48
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@dolfim-ibm dolfim-ibm marked this pull request as ready for review September 18, 2024 05:42
@dolfim-ibm dolfim-ibm merged commit 442443a into main Sep 18, 2024
4 checks passed
@dolfim-ibm dolfim-ibm deleted the fix/propagate-tablecell-types branch September 18, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants