Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine conversion result #52

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: refine conversion result #52

merged 1 commit into from
Aug 27, 2024

Conversation

vagenas
Copy link
Contributor

@vagenas vagenas commented Aug 27, 2024

  • fields output and assembled need not be optional
  • introduced "synonym" ConversionResult for ConvertedDocument and deprecated the latter

@vagenas vagenas requested review from cau-git and dolfim-ibm August 27, 2024 07:47
- fields `output` & `assembled` need not be optional
- introduced "synonym" `ConversionResult` for `ConvertedDocument` & deprecated the latter

Signed-off-by: Panos Vagenas <[email protected]>
@vagenas vagenas force-pushed the refine-conversion-result branch from 6b2a3bc to 3b73068 Compare August 27, 2024 08:02
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vagenas vagenas merged commit e46a66a into main Aug 27, 2024
7 checks passed
@vagenas vagenas deleted the refine-conversion-result branch August 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants